You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Abhijeetmishr (via GitHub)" <gi...@apache.org> on 2023/04/09 08:19:38 UTC

[GitHub] [rocketmq] Abhijeetmishr opened a new pull request, #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache

Abhijeetmishr opened a new pull request, #6553:
URL: https://github.com/apache/rocketmq/pull/6553

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   #6535 In proxy ClusterMetadataService, we use guava LoadingCache to cache topicConfig and subscriptionGroupConfig.
   Replaced guava LoadingCache with Cafeine Cache similar to used in proxy TopicRouteService.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] Abhijeetmishr commented on pull request #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache

Posted by "Abhijeetmishr (via GitHub)" <gi...@apache.org>.
Abhijeetmishr commented on PR #6553:
URL: https://github.com/apache/rocketmq/pull/6553#issuecomment-1501104770

   @Oliverwqcwrw @aaron-ai Please review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] codecov-commenter commented on pull request #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6553:
URL: https://github.com/apache/rocketmq/pull/6553#issuecomment-1501343750

   ## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6553?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6553](https://codecov.io/gh/apache/rocketmq/pull/6553?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4e576f) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9574165fe38c51f789eebbba485291bee505ab2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9574165) will **decrease** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #6553      +/-   ##
   =============================================
   - Coverage      43.16%   43.09%   -0.07%     
   + Complexity      9014     8994      -20     
   =============================================
     Files           1107     1107              
     Lines          78255    78253       -2     
     Branches       10201    10201              
   =============================================
   - Hits           33777    33723      -54     
   - Misses         40241    40304      +63     
   + Partials        4237     4226      -11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...proxy/service/metadata/ClusterMetadataService.java](https://codecov.io/gh/apache/rocketmq/pull/6553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvbWV0YWRhdGEvQ2x1c3Rlck1ldGFkYXRhU2VydmljZS5qYXZh) | `77.41% <100.00%> (-0.71%)` | :arrow_down: |
   
   ... and [31 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] drpmma commented on pull request #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache

Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma commented on PR #6553:
URL: https://github.com/apache/rocketmq/pull/6553#issuecomment-1515778163

   close for duplication #6554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] drpmma closed pull request #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache

Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma closed pull request #6553: [#6535] Replace guava LoadingCache with caffeine LoadingCache
URL: https://github.com/apache/rocketmq/pull/6553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org