You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/15 14:57:27 UTC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11589: MINOR: update log and method name

wcarlson5 commented on a change in pull request #11589:
URL: https://github.com/apache/kafka/pull/11589#discussion_r769705381



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -153,7 +153,7 @@ public void maybeNotifyTopologyVersionWaiters(final String threadName) {
                     if (threadVersions.values().stream().allMatch(t -> t >= topologyVersionWaitersVersion)) {
                         topologyVersionWaiters.future.complete(null);
                         iterator.remove();
-                        log.info("Thread {} is now on topology version {}", threadName, topologyVersionWaiters.topologyVersion);
+                        log.info("All threads are now on topology version {}", topologyVersionWaiters.topologyVersion);

Review comment:
       this log line only prints once not once per thread. each waiter also has a different version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org