You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2024/04/12 11:15:00 UTC
[jira] [Commented] (IGNITE-22026) Fix incorrect retry logic in GridCacheIoManager send method

    [ https://issues.apache.org/jira/browse/IGNITE-22026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836562#comment-17836562 ] 

Ignite TC Bot commented on IGNITE-22026:
----------------------------------------

{panel:title=Branch: [pull/11311/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/11311/head] Base: [master] : New Tests (8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Cache 13{color} [[tests 8|https://ci2.ignite.apache.org/viewLog.html?buildId=7821181]]
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSend[retryCnt=0] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSendOrdered[retryCnt=1] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSendOrdered[retryCnt=0] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSend[retryCnt=3] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSendOrdered[retryCnt=10] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSend[retryCnt=1] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSendOrdered[retryCnt=3] - PASSED{color}
* {color:#013220}IgniteCacheTestSuite13: GridCacheIoManagerRetryTest.testSend[retryCnt=10] - PASSED{color}

{panel}
[TeamCity *--&gt; Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=7821279&amp;buildTypeId=IgniteTests24Java8_RunAll]

> Fix incorrect retry logic in GridCacheIoManager send method
> -----------------------------------------------------------
>
>                 Key: IGNITE-22026
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22026
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Ilya Shishkov
>            Assignee: Ilya Shishkov
>            Priority: Minor
>              Labels: ise
>         Attachments: GridCacheIoManagerRetryTest.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{GridCacheIoManager#send}}[1] and {{GridCacheIoManager#sendOrderedMessage}}[2] have incorrect {{retryCnt}} comparison in catch block and real retries count will be one less, than configured.
> Thus, if you set {{IgniteConfiguration#setNetworkSendRetryCount}} to 1 and {{IgniteCheckedException}} has been thrown during sending of message because of network timeout, error, etc., then no actual retries will happen and message will be lost.
> Reproducer:  [^GridCacheIoManagerRetryTest.patch] 
> Links:
> # https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1222
> # https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1289



--
This message was sent by Atlassian Jira
(v8.20.10#820010)