You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/29 13:41:17 UTC
[GitHub] [kafka] vinothchandar opened a new pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker …
vinothchandar opened a new pull request #8948:
URL: https://github.com/apache/kafka/pull/8948
…tests
- Preferred when version >= 2.6.0
- Small renaming to make context clearer
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-659508365
ok, that works for me. LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vinothchandar commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-658236034
@cmccabe we already discussed the same. I still think for the scope for the issue, this PR suffices. let us know what you think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vinothchandar commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-659531282
Thanks @cmccabe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #8948:
URL: https://github.com/apache/kafka/pull/8948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-657725929
@vinothchandar @cmccabe I've assigned https://issues.apache.org/jira/browse/KAFKA-10258 to me and will deal with `use_zk_connection` there. It would be great if we could merge this PR without my involvement to keep it to 1 author.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vinothchandar commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-656251801
@cmccabe this PR is a sub task under KAFKA-10131, which tracks the bigger goal. I filed a new issue explicitly targetting removal of `use_zk_connection` . For this pr, the public methods affects `alter_message_format`/`set_unclean_leader_election` don't offer this flag..
So this PR should be fine for this scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8948: KAFKA-10174: Prefer --bootstrap-server for configs command in ducker tests
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8948:
URL: https://github.com/apache/kafka/pull/8948#issuecomment-657616089
Maybe just transition this over to @rondagostino to see what he thinks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org