You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by a_adrian <a....@googlemail.com> on 2009/03/31 17:53:24 UTC

Some examples from SVN seem broken...

Some of the examples in SVN seems to be broken.
1. if you build click-examples from svn, and go to e.g. Table/Table Decorator
2. Click one item to edit it
3. Edit e.g. the name to something else
4. Click OK to save.
5. an error page will be displayed as follows
--------------------------------------------------------
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
	at java.lang.String.charAt(String.java:687)
	at org.apache.click.Page.setRedirect(Page.java:1102)
	at org.apache.click.examples.page.EditCustomer.onOkClick(EditCustomer.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.click.util.ClickUtils.invokeListener(ClickUtils.java:1743)
	at org.apache.click.util.ActionListenerAdaptor.onAction(ActionListenerAdaptor.java:61)
	at org.apache.click.ControlRegistry.fireActionEvents(ControlRegistry.java:150)
	at org.apache.click.ClickServlet.performOnProcess(ClickServlet.java:1485)
	at org.apache.click.ClickServlet.processPage(ClickServlet.java:505)
	at org.apache.click.ClickServlet.handleRequest(ClickServlet.java:335)
	at org.apache.click.ClickServlet.doPost(ClickServlet.java:271)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.click.extras.filter.PerformanceFilter.doFilter(PerformanceFilter.java:395)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.click.extras.cayenne.DataContextFilter.doFilter(DataContextFilter.java:241)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.click.examples.util.DatabaseInitFilter.doFilter(DatabaseInitFilter.java:106)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
	at java.lang.Thread.run(Thread.java:619)
-- 
View this message in context: http://n2.nabble.com/Some-examples-from-SVN-seem-broken...-tp2563798p2563798.html
Sent from the click-development mailing list archive at Nabble.com.


Re: Some examples from SVN seem broken...

Posted by Bob Schellink <sa...@gmail.com>.
Bob Schellink wrote:
> This is due to https://issues.apache.org/jira/browse/CLK-508.
> 
> Its caused by a public hidden field (referrerField) that is added to 
> Page but never processed, meanings its never bound to its request 
> parameter. The reason its never processed is because CLK-508 moved the 
> Form submitCheck down to the Field level and this check returns false, 
> because the Form was not submitted.


Checked in a fix for this issue by adding an extra check in 
Field.canProcess based on whether the Field is added directly to the 
Page. If it is the Field will be processed.

CLK-508 is hanging on by a very thin thread.

Re: Some examples from SVN seem broken...

Posted by Bob Schellink <sa...@gmail.com>.
This is due to https://issues.apache.org/jira/browse/CLK-508.

Its caused by a public hidden field (referrerField) that is added to 
Page but never processed, meanings its never bound to its request 
parameter. The reason its never processed is because CLK-508 moved the 
Form submitCheck down to the Field level and this check returns false, 
because the Form was not submitted.

Don't see a way around this so will probably roll back CLK-508.

Thanks for picking it up so early.

kind regards

bob



a_adrian wrote:
> Some of the examples in SVN seems to be broken.
> 1. if you build click-examples from svn, and go to e.g. Table/Table Decorator
> 2. Click one item to edit it
> 3. Edit e.g. the name to something else
> 4. Click OK to save.
> 5. an error page will be displayed as follows
> --------------------------------------------------------
> java.lang.StringIndexOutOfBoundsException: String index out of range: 0
> 	at java.lang.String.charAt(String.java:687)
> 	at org.apache.click.Page.setRedirect(Page.java:1102)
> 	at org.apache.click.examples.page.EditCustomer.onOkClick(EditCustomer.java:118)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.apache.click.util.ClickUtils.invokeListener(ClickUtils.java:1743)
> 	at org.apache.click.util.ActionListenerAdaptor.onAction(ActionListenerAdaptor.java:61)
> 	at org.apache.click.ControlRegistry.fireActionEvents(ControlRegistry.java:150)
> 	at org.apache.click.ClickServlet.performOnProcess(ClickServlet.java:1485)
> 	at org.apache.click.ClickServlet.processPage(ClickServlet.java:505)
> 	at org.apache.click.ClickServlet.handleRequest(ClickServlet.java:335)
> 	at org.apache.click.ClickServlet.doPost(ClickServlet.java:271)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.click.extras.filter.PerformanceFilter.doFilter(PerformanceFilter.java:395)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.click.extras.cayenne.DataContextFilter.doFilter(DataContextFilter.java:241)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.click.examples.util.DatabaseInitFilter.doFilter(DatabaseInitFilter.java:106)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
> 	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
> 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
> 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
> 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
> 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
> 	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
> 	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
> 	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
> 	at java.lang.Thread.run(Thread.java:619)