You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/04/06 19:16:05 UTC
[GitHub] activemq-artemis pull request #1180: ARTEMIS-1096 Changing Global Max Size's...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1180
ARTEMIS-1096 Changing Global Max Size's default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis global-max
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1180
----
commit 708730cbc5e10a66ac9d94e92bc0cc9c190a35c1
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-04-06T19:03:25Z
ARTEMIS-1096 Changing Global Max Size's default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1180: ARTEMIS-1096 Changing Global Max Size's defaul...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1180
I see your point, but we're already flooding it with silly (IMO) warns about not having dead-letter and expiry queues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1180: ARTEMIS-1096 Changing Global Max Size's...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1180: ARTEMIS-1096 Changing Global Max Size's defaul...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1180
or the opposite.. set it on our testsuite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1180: ARTEMIS-1096 Changing Global Max Size's defaul...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1180
It might be good to explicitly log what is being used for the global-max-size (e.g. an INFO level) when using the default so users understand it's using Xmx/2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1180: ARTEMIS-1096 Changing Global Max Size's defaul...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1180
that will flood the testsuite though :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1180: ARTEMIS-1096 Changing Global Max Size's defaul...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1180
I need a mental break with a light task.. I will deal with the DLQ message as well.
perhaps we could have a static testMode propery somewhere that we disable only through the Run command?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---