You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/20 04:46:54 UTC
[GitHub] zeppelin pull request #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar ...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2265
[ZEPPELIN-2427] Hide navbar and noteAction bar when scrolling down
### What is this PR for?
Hide navbar and noteAction bar when scrolling down to
- **widen view area**
Here are few famous services which hiding their navbar too.
- https://www.kaggle.com/c/titanic
- https://github.com/1ambda (profile page)
### What type of PR is it?
[Improvement]
### Todos
* [x] - Add headroom.js
* [x] - Filter out useless dependencies
* [x] - Apply headroom.js
### What is the Jira issue?
[ZEPPELIN-2427](https://issues.apache.org/jira/browse/ZEPPELIN-2427)
### How should this be tested?
1. Open Zeppelin
2. Scroll down, up to see whether navbar and note action bar are hided or not.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2265
----
commit 0db5f3bde766cd6e27cb6b5f8f8b0badba27f3b1
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-20T04:34:02Z
feat: Add headroom dep
commit 39e37154ac68a7bedc30a93c7dd66b5f27c805dd
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-20T04:34:22Z
fix: Filter out useless deps
commit 7b7638803215699815827a3a8d40c8ae1e749370
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-20T04:34:36Z
feat: Apply headroom.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Tested and it works well!
Although i really really like this improvement because it allow utilize small screen more efficiently, i'd like to open this PR for next few more days for further feedbacks since it's noticeable UX change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Cool!
Then to reach to the menu, some users who have lots of paragraphs have to spend much time to scroll up. Then how about sticky "go to top" like button at bottom-right side instead? I mean in another PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Tested and it looks great! +1 for this change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@1ambda Yeah right right I misapprehended actually. It was my bad.
Btw I wanted to test this locally but failed when I run `yarn install` and got this below 404 error.
```
[{
"code": "EHTTP",
"data": {
"endpoint": {
"name": "headroom.js",
"source": "https://unpkg.com/headroom.js/bower.zip",
"target": "*"
},
"resolver": {
"name": "headroom.js",
"source": "https://unpkg.com/headroom.js/bower.zip",
"target": "*"
}
},
"id": "EHTTP",
"level": "error",
"message": "Status code of 404",
"stacktrace": "Error: Status code of 404\n at createError (/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/util/createError.js:4:15)\n at Request.<anonymous> (/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/util/download.js:91:36)\n at emitOne (events.js:101:20)\n at Request.emit (events.js:188:7)\n at Request.onRequestResponse (/Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/node_modules/bower/lib/node_modules/request/request.js:951:10)\n at emitOne (events.js:96:13)\n at ClientRequest.emit (events.js:188:7)\n at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:474:21)\n at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)\n at TLSSocket.socketOnData (_http_client.js:363:20)"
}]
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
```
Could you point me how can I install `headroom.js`? Did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@AhyoungRyu you can get navbar again by scrolling up few pixels. it's not necessary to go to the top.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@Leemoonsoo Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2265
This PR has been opened for last week.
LGTM and Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
It seems that `unpkg.com` is broken. Before, i was able to download it (CI as well)
```
$ headroom.js git:(ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down) \u2717 pwd
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-feature/zeppelin-web/bower_components/headroom.js
$ headroom.js git:(ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down) \u2717 ls
bower.json dist
$ headroom.js git:(ZEPPELIN-2427/hide-navbar-and-noteActionBar-scrolling-down) \u2717 cat bower.json| grep version
"version": "0.9.3"
```
Let me use npm instead of. The maintainer might not support bower.
- https://github.com/WickyNilliams/headroom.js/issues/240#issuecomment-288107664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@AhyoungRyu I'v just updated code.
But Jenkins is not triggered.
- (Travis) https://travis-ci.org/1ambda/zeppelin/builds/224840876
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@Leemoonsoo Please help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---