You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/20 05:47:45 UTC
[GitHub] [doris] morrySnow opened a new pull request, #12767: [enhancement](Nereids) open all reorder
morrySnow opened a new pull request, #12767:
URL: https://github.com/apache/doris/pull/12767
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12767: [enhancement](Nereids) turn on all reorder rule that needed by zig-zag tree
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12767:
URL: https://github.com/apache/doris/pull/12767#issuecomment-1253915611
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #12767: [enhancement](Nereids) turn on all reorder rule that needed by zig-zag tree
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #12767:
URL: https://github.com/apache/doris/pull/12767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #12767: [enhancement](Nereids) open all reorder
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #12767:
URL: https://github.com/apache/doris/pull/12767#discussion_r974986642
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleSet.java:
##########
@@ -56,13 +56,13 @@
*/
public class RuleSet {
public static final List<Rule> EXPLORATION_RULES = planRuleFactories()
- .add(JoinCommute.LEFT_DEEP)
+ .add(JoinCommute.ZIG_ZAG)
.add(InnerJoinLAsscom.INSTANCE)
.add(InnerJoinLAsscomProject.INSTANCE)
.add(OuterJoinLAsscom.INSTANCE)
.add(OuterJoinLAsscomProject.INSTANCE)
- .add(SemiJoinLogicalJoinTranspose.LEFT_DEEP)
- .add(SemiJoinLogicalJoinTransposeProject.LEFT_DEEP)
+ .add(SemiJoinLogicalJoinTranspose.ALL)
+ .add(SemiJoinLogicalJoinTransposeProject.ALL)
Review Comment:
use leftDeep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #12767: [enhancement](Nereids) open all reorder
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12767:
URL: https://github.com/apache/doris/pull/12767#discussion_r975063341
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##########
@@ -87,8 +87,16 @@ public Plan newTopJoin() {
newBottomJoin.getJoinReorderContext().setHasLAsscom(false);
newBottomJoin.getJoinReorderContext().setHasCommute(false);
- Plan left = PlanUtils.projectOrSelf(newLeftProjects, newBottomJoin);
- Plan right = PlanUtils.projectOrSelf(newRightProjects, b);
+ Plan left = newBottomJoin;
+ if (!newLeftProjects.stream().map(NamedExpression::toSlot).collect(Collectors.toSet())
+ .equals(newBottomJoin.getOutputSet())) {
+ left = PlanUtils.projectOrSelf(newLeftProjects, newBottomJoin);
+ }
+ Plan right = b;
+ if (!newRightProjects.stream().map(NamedExpression::toSlot).collect(Collectors.toSet())
+ .equals(b.getOutputSet())) {
+ right = PlanUtils.projectOrSelf(newRightProjects, b);
Review Comment:
todo refactor it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12767: [enhancement](Nereids) turn on all reorder rule that needed by zig-zag tree
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12767:
URL: https://github.com/apache/doris/pull/12767#issuecomment-1253915676
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org