You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/09 11:34:15 UTC

[I] Remove the deprecated ExpansionGreedyScheduleGenerator from the amber engine [texera]

aglinxinyuan opened a new issue, #7444:
URL: https://github.com/apache/texera/issues/7444

   ### Task Summary
   
   `ExpansionGreedyScheduleGenerator` has been unreachable since #3144 and formally deprecated since #3542. Nothing in the repo references it except its own spec.
   
   | Symbol | Location | Lines (src + spec) | Status |
   | --- | --- | ---: | --- |
   | `ExpansionGreedyScheduleGenerator` | `amber/.../engine/architecture/scheduling/` | 495 + 337 | `@deprecated` since #3542 (2025-07-09) |
   
   #3144 ("Refactoring of Schedule Generation", 2024-12-14) made `CostBasedScheduleGenerator` the only generator the engine builds — `WorkflowScheduler.scala:46` instantiates it directly:
   
   ```
   WorkflowScheduler -> new CostBasedScheduleGenerator(...)   (live)
                        ExpansionGreedyScheduleGenerator      (no caller since #3144)
   ```
   
   #3542 then annotated the class with the removal notice it still carries:
   
   > This greedy schedule generator will be removed in the future. Use `CostBasedScheduleGenerator` instead.
   
   There is no generator-selection switch to keep it reachable: the `schedule-generator` block in `application.conf` holds only CostBased tuning parameters (`max-concurrent-regions`, `use-global-search`, `use-top-down-search`, `search-timeout`), and a case-insensitive search for `greedy` across `.conf` / `.yml` / `.yaml` / `.json` / `.properties` returns nothing. The abstract base `ScheduleGenerator` stays — `CostBasedScheduleGenerator` extends it.
   
   Acting on the deprecation notice is a pure deletion with no behaviour change: −832 lines.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove the deprecated ExpansionGreedyScheduleGenerator from the amber engine [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7444:
URL: https://github.com/apache/texera/issues/7444#issuecomment-5231302329

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @aglinxinyuan!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Remove the deprecated ExpansionGreedyScheduleGenerator from the amber engine [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #7444: Remove the deprecated ExpansionGreedyScheduleGenerator from the amber engine
URL: https://github.com/apache/texera/issues/7444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org