[GitHub] [netbeans] matthiasblaesing commented on pull request #5983: [JS] Fix ConcurrentModificationException scanning export class {} with multiple members

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #5983:
URL: https://github.com/apache/netbeans/pull/5983#issuecomment-1560023057

   > > Fix applies same pattern, that is used in other places where ModelUtils#moveProperty is invoked.
   > 
   > i see one change in ModelVisitor. This sentence sounds like there should be multiple fixes in this PR?
   
   Missunderstanding, I meant, that other location with similar structure, already hold the fix for `ConcurrentModificationException`:
   
   https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/JsObjectImpl.java#L488-L491
   
   https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/ModelVisitor.java#L1014-L1017
   
   https://github.com/apache/netbeans/blob/788ba1f72534348ac9e45210c7edd2428659d2b4/webcommon/javascript2.model/src/org/netbeans/modules/javascript2/model/api/ModelUtils.java#L1917-L1920
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists