You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2016/12/22 17:13:28 UTC
Review Request 54987: Updated `docs/monitoring/md` for new slave
event queue metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
Bugs: MESOS-6831
https://issues.apache.org/jira/browse/MESOS-6831
Repository: mesos
Description
-------
Updated `docs/monitoring/md` for new slave event queue metrics.
Diffs
-----
docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222
Diff: https://reviews.apache.org/r/54987/diff/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 54987: Updated `docs/monitoring/md` for new slave
event queue metrics.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/#review163092
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
docs/monitoring.md (lines 1532 - 1563)
<https://reviews.apache.org/r/54987/#comment234534>
Put it after `#### Messages`, refer what we do in https://github.com/apache/mesos/blob/1.1.0/docs/monitoring.md#event-queue
- haosdent huang
On Dec. 22, 2016, 5:13 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54987/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 5:13 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
>
>
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `docs/monitoring/md` for new slave event queue metrics.
>
>
> Diffs
> -----
>
> docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222
>
> Diff: https://reviews.apache.org/r/54987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 54987: Updated `docs/monitoring/md` for new slave
event queue metrics.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/#review160001
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Lai
On Dec. 22, 2016, 5:13 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54987/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 5:13 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
>
>
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `docs/monitoring/md` for new slave event queue metrics.
>
>
> Diffs
> -----
>
> docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222
>
> Diff: https://reviews.apache.org/r/54987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 54987: Updated `docs/monitoring/md` for new agent
event queue metrics.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/
-----------------------------------------------------------
(Updated April 30, 2018, 2:09 p.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
Changes
-------
Rebase.
Bugs: MESOS-6831
https://issues.apache.org/jira/browse/MESOS-6831
Repository: mesos
Description
-------
Updated `docs/monitoring/md` for new agent event queue metrics.
Diffs (updated)
-----
docs/monitoring.md c20b99eb32a50830ea6f66b5bdbfcabe45fc6ecb
Diff: https://reviews.apache.org/r/54987/diff/2/
Changes: https://reviews.apache.org/r/54987/diff/1-2/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 54987: Updated `docs/monitoring/md` for new agent
event queue metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/#review163112
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54986, 54987]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 26, 2017, 4:29 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54987/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:29 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
>
>
> Bugs: MESOS-6831
> https://issues.apache.org/jira/browse/MESOS-6831
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `docs/monitoring/md` for new agent event queue metrics.
>
>
> Diffs
> -----
>
> docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222
>
> Diff: https://reviews.apache.org/r/54987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 54987: Updated `docs/monitoring/md` for new agent
event queue metrics.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54987/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 4:29 a.m.)
Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Jason Lai.
Summary (updated)
-----------------
Updated `docs/monitoring/md` for new agent event queue metrics.
Bugs: MESOS-6831
https://issues.apache.org/jira/browse/MESOS-6831
Repository: mesos
Description (updated)
-------
Updated `docs/monitoring/md` for new agent event queue metrics.
Diffs
-----
docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222
Diff: https://reviews.apache.org/r/54987/diff/
Testing
-------
Thanks,
Zhitao Li