[GitHub] [iceberg] hililiwei commented on a diff in pull request #4325: Spark: Skip corrupt files in Spark Procedures and Actions

["hililiwei (via GitHub)" <gi...@apache.org>]

hililiwei commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r1177651179


##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -978,6 +1044,11 @@ private void validateTables(String source, String dest)
 
   private long expectedFilesCount(String source)
       throws NoSuchDatabaseException, NoSuchTableException, ParseException {
+    return expectedFiles(source).count();
+  }
+
+  private Stream<File> expectedFiles(String source)

Review Comment:
   > Why do we need this change?
   
   Existing cases that get the length of the result are sufficient, but newly added cases need to get the elements.
   
   
   
   > Seems like we never really use this as a stream? Could we just make it a list?
   
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org