You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/09/19 23:20:44 UTC
[jira] Created: (THRIFT-145) NPE in TNonblockingServer
NPE in TNonblockingServer
-------------------------
Key: THRIFT-145
URL: https://issues.apache.org/jira/browse/THRIFT-145
Project: Thrift
Issue Type: Bug
Components: Library (Java)
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
{code}
Exception in thread "Thread-2" java.lang.NullPointerException
at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
{code}
Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-145) NPE in TNonblockingServer
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-145.
--------------------------------
Resolution: Fixed
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145-v2.patch, thrift-145-v3.patch, thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-145) NPE in TNonblockingServer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-145:
---------------------------------
Attachment: thrift-145-v2.patch
This is a slightly better version of a fix. It seems to get rid of the error in my testing.
Can someone please review and commit if it looks alright?
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145-v2.patch, thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-145) NPE in TNonblockingServer
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636109#action_12636109 ]
David Reiss commented on THRIFT-145:
------------------------------------
I don't really object to pulling the declaration of frameBuffer out of the try, but I don't see the point of it either. I wonder if it would also be good to move the exception reporting above the close so that it happens even if there is some other sort of exception in the closing.
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145-v2.patch, thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-145) NPE in TNonblockingServer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-145:
---------------------------------
Attachment: thrift-145-v3.patch
Good call. I changed the FrameBuffer declaration and printed the exception above the exception cleanup.
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145-v2.patch, thrift-145-v3.patch, thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-145) NPE in TNonblockingServer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-145:
---------------------------------
Patch Info: [Patch Available]
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-145) NPE in TNonblockingServer
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-145:
---------------------------------
Attachment: thrift-145.patch
I'm not positive (because I don't know how to repro the problem) but I think this should resolve the issue.
> NPE in TNonblockingServer
> -------------------------
>
> Key: THRIFT-145
> URL: https://issues.apache.org/jira/browse/THRIFT-145
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-145.patch
>
>
> {code}
> Exception in thread "Thread-2" java.lang.NullPointerException
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.cleanupSelectionkey(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.handleAccept(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.select(Unknown Source)
> at com.facebook.thrift.server.TNonblockingServer$SelectThread.run(Unknown Source)
> {code}
> Unsure of the cause, but this should be handled more elegantly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.