You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Victor J. Orlikowski" <v....@gte.net> on 2000/08/31 19:30:34 UTC
[PATCH] Remove needless const-ipation.
The const in the code below breaks the build on AIX.
Index: src/support/ab.c
===================================================================
RCS file: /cvs/apache/apache-2.0/src/support/ab.c,v
retrieving revision 1.26
diff -u -r1.26 ab.c
--- ab.c 2000/08/10 12:52:37 1.26
+++ ab.c 2000/08/31 17:15:56
@@ -1008,7 +1008,7 @@
#endif
apr_initopt(&opt, cntxt, argc, argv);
- while ((status = apr_getopt(opt, "n:c:t:T:p:v:kVhwix:y:z:C:H:P:A:", &c, &optarg)) == APR_SUCCESS) {
+ while ((status = apr_getopt(opt, "n:c:t:T:p:v:kVhwix:y:z:C:H:P:A:", &c, (const char**) &optarg)) == APR_SUCCESS) {
switch (c) {
case 'n':
requests = atoi(optarg);
Victor
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com
Re: [PATCH] Remove needless const-ipation.
Posted by "Victor J. Orlikowski" <v....@gte.net>.
Whoops! Make that "Please const-ipate".
Thanks for the catch.
Victor
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
vjo@raleigh.ibm.com
vjo@us.ibm.com
Re: [PATCH] Remove needless const-ipation.
Posted by "Jeffrey W. Baker" <jw...@acm.org>.
On Thu, 31 Aug 2000, Victor J. Orlikowski wrote:
> The const in the code below breaks the build on AIX.
>
> Index: src/support/ab.c
> ===================================================================
> RCS file: /cvs/apache/apache-2.0/src/support/ab.c,v
> retrieving revision 1.26
> diff -u -r1.26 ab.c
> --- ab.c 2000/08/10 12:52:37 1.26
> +++ ab.c 2000/08/31 17:15:56
> @@ -1008,7 +1008,7 @@
> #endif
>
> apr_initopt(&opt, cntxt, argc, argv);
> - while ((status = apr_getopt(opt, "n:c:t:T:p:v:kVhwix:y:z:C:H:P:A:", &c, &optarg)) == APR_SUCCESS) {
> + while ((status = apr_getopt(opt, "n:c:t:T:p:v:kVhwix:y:z:C:H:P:A:", &c, (const char**) &optarg)) == APR_SUCCESS) {
> switch (c) {
> case 'n':
> requests = atoi(optarg);
Pardon me if I'm being dense, but it looks like your patch is adding a
const, not removing one.
-jwb