You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Au-Miner (via GitHub)" <gi...@apache.org> on 2026/05/21 11:11:46 UTC
[PR] [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR [flink]
Au-Miner opened a new pull request, #28220:
URL: https://github.com/apache/flink/pull/28220
## What is the purpose of the change
`PlannerModule` extracted the `flink-table-planner` JAR into the JVM default temp directory (e.g. `/tmp`) regardless of the `io.tmp.dirs` value configured in `flink-conf.yaml`. This fix makes the loader honor the configured directory.
## Brief change log
- Replace `new Configuration()` with `GlobalConfiguration.loadConfiguration()` in `PlannerModule`'s constructor so the loaded `flink-conf.yaml` is used when resolving the temp directory.
- Extract the temp-directory resolution into a package-private `PlannerModule#resolveTmpDirectory(Configuration)` (annotated `@VisibleForTesting`) to keep the constructor focused and to make the logic unit-testable.
## Verifying this change
Added `PlannerModuleTest` with two cases: `resolveTmpDirectoryHonorsIoTmpDirsFromYaml` writes a `config.yaml` with a custom `io.tmp.dirs`, loads it via `GlobalConfiguration.loadConfiguration(configDir, null)`, and asserts `PlannerModule.resolveTmpDirectory(...)` returns the configured path; `resolveTmpDirectoryFallsBackToDefaultWhenIoTmpDirsUnset` asserts the fallback to `CoreOptions.TMP_DIRS` default for an empty configuration.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28220:
URL: https://github.com/apache/flink/pull/28220#issuecomment-5739968856
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28220:
URL: https://github.com/apache/flink/pull/28220#issuecomment-4507664399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6da62b71e3f4167655e622235e13a951d9b2636f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6da62b71e3f4167655e622235e13a951d9b2636f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6da62b71e3f4167655e622235e13a951d9b2636f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #28220: [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR
URL: https://github.com/apache/flink/pull/28220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36567][table] Honor io.tmp.dirs from flink-conf.yaml when extracting planner JAR [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28220:
URL: https://github.com/apache/flink/pull/28220#issuecomment-5352247052
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org