[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #30030: Improve install instruction for test package

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #30030:
URL: https://github.com/apache/airflow/pull/30030#discussion_r1132887783


##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -190,16 +190,16 @@ def prepare_pypi_packages(version, version_suffix, repo_root):
         console_print("PyPI packages prepared")
 
 
-def push_packages_to_test_pypi():
+def push_packages_to_test_pypi(version):
     if confirm_action("Do you want to push packages to test PyPI?"):
         run_command(["twine", "upload", "-r", "pypitest", "dist/*"], dry_run_override=DRY_RUN, check=True)
         console_print("Packages pushed to test PyPI")
         console_print(
             "Verify that the test package looks good by downloading it and installing it into a virtual "
             "environment. The package download link is available at: "
-            "https://test.pypi.org/project/apache-airflow/#files"
-            "Install it with the appropriate constraint file, for instance: "
-            "pip install <download_link> --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc1/constraints-3.8.txt"  # noqa: 501
+            "https://test.pypi.org/project/apache-airflow/#files "
+            "Install it with the appropriate constraint file, adapt python version: "
+            f"pip install https://test.pypi.org/simple/ apache-airflow=={version} --constraint https://raw.githubusercontent.com/apache/airflow/constraints-{version}/constraints-3.8.txt"  # noqa: 501

Review Comment:
   Can you try with `apache-airflow==2.5.2rc1` ? rc number seems wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org