You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by David Rees <dr...@gmail.com> on 2011/04/01 00:38:34 UTC
Re: TAP5-742: Fixed in 5.2.5?
On Wed, Mar 30, 2011 at 10:22 AM, Igor Drobiazko
<ig...@gmail.com> wrote:
> Also this one is only fixed for 5.3.0:
>
> https://issues.apache.org/jira/browse/TAP5-1378
I can confirm that TAP5-1378 is not fixed in 5.2.5. It's a show-stopper.
Is the only way to get this fix to use 5.2-SNAPSHOT builds?
I also don't see that the source for 5.2.5 was tagged anywhere.
I would have expected to see that here:
http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/
I'm a bit confused as the ticket indicates that the changes were
committed to the 5.2-maint branch? If so - from what tree was the
5.2.5 release built from? It's impossible to tell since the release
wasn't tagged.
-Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by David Rees <dr...@gmail.com>.
On Thu, Mar 31, 2011 at 4:12 PM, David Rees <dr...@gmail.com> wrote:
> It appears that 5.2.5 (as seen here
> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/5.2.5/)
> was tagged from the maint-5.2 branch.
>
> Looking at the source bundles that have been released (downloaded from
> http://www.apache.org/dist//tapestry/) - those appear to have the fix
> for TAP5-1378.
>
> So it appears that either the changes checked in to TAP5-1378 don't
> fix the bug completely, or I am suffering from another bug.
Looks like I am suffering from another issue - TAP5-1378 is indeed in
the 5.2.5 release.
The issue I had (which I confused w/TAP5-1378) is that I had recently
upgraded to T5.2 from T5.1 but lost my BaseURLSource override (we
don't use the @Secure tag - instead rely on the deployment details to
determine if the whole app runs under SSL or not).
Sorry for the noise!
-Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by David Rees <dr...@gmail.com>.
It appears that 5.2.5 (as seen here
http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/5.2.5/)
was tagged from the maint-5.2 branch.
Looking at the source bundles that have been released (downloaded from
http://www.apache.org/dist//tapestry/) - those appear to have the fix
for TAP5-1378.
So it appears that either the changes checked in to TAP5-1378 don't
fix the bug completely, or I am suffering from another bug.
-Dave
On Thu, Mar 31, 2011 at 4:04 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> I hope that's not the case, it would imply that the tag was generated
> from trunk and not from the 5-2-maint branch.
>
> On Thu, Mar 31, 2011 at 4:03 PM, David Rees <dr...@gmail.com> wrote:
>> Thanks - just found that - was confused by the 5.2.5 tag deletion in
>> the mail archives.
>>
>> The question is: The tag itself appears to have the fix for TAP5-1378
>> but the release doesn't? (at least the issue described by TAP5-1378
>> still doesn't work for me)
>>
>> -Dave
>>
>> On Thu, Mar 31, 2011 at 3:43 PM, Kalle Korhonen
>> <ka...@gmail.com> wrote:
>>> The tag is at http://svn.apache.org/repos/asf/tapestry/tapestry5/tags/releases/5.2.5/
>>>
>>> Kalle
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by Howard Lewis Ship <hl...@gmail.com>.
I hope that's not the case, it would imply that the tag was generated
from trunk and not from the 5-2-maint branch.
On Thu, Mar 31, 2011 at 4:03 PM, David Rees <dr...@gmail.com> wrote:
> Thanks - just found that - was confused by the 5.2.5 tag deletion in
> the mail archives.
>
> The question is: The tag itself appears to have the fix for TAP5-1378
> but the release doesn't? (at least the issue described by TAP5-1378
> still doesn't work for me)
>
> -Dave
>
> On Thu, Mar 31, 2011 at 3:43 PM, Kalle Korhonen
> <ka...@gmail.com> wrote:
>> The tag is at http://svn.apache.org/repos/asf/tapestry/tapestry5/tags/releases/5.2.5/
>>
>> Kalle
>>
>> On Thu, Mar 31, 2011 at 3:38 PM, David Rees <dr...@gmail.com> wrote:
>>> On Wed, Mar 30, 2011 at 10:22 AM, Igor Drobiazko
>>> <ig...@gmail.com> wrote:
>>>> Also this one is only fixed for 5.3.0:
>>>>
>>>> https://issues.apache.org/jira/browse/TAP5-1378
>>>
>>> I can confirm that TAP5-1378 is not fixed in 5.2.5. It's a show-stopper.
>>>
>>> Is the only way to get this fix to use 5.2-SNAPSHOT builds?
>>>
>>> I also don't see that the source for 5.2.5 was tagged anywhere.
>>>
>>> I would have expected to see that here:
>>> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/
>>>
>>> I'm a bit confused as the ticket indicates that the changes were
>>> committed to the 5.2-maint branch? If so - from what tree was the
>>> 5.2.5 release built from? It's impossible to tell since the release
>>> wasn't tagged.
>>>
>>> -Dave
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by David Rees <dr...@gmail.com>.
Thanks - just found that - was confused by the 5.2.5 tag deletion in
the mail archives.
The question is: The tag itself appears to have the fix for TAP5-1378
but the release doesn't? (at least the issue described by TAP5-1378
still doesn't work for me)
-Dave
On Thu, Mar 31, 2011 at 3:43 PM, Kalle Korhonen
<ka...@gmail.com> wrote:
> The tag is at http://svn.apache.org/repos/asf/tapestry/tapestry5/tags/releases/5.2.5/
>
> Kalle
>
> On Thu, Mar 31, 2011 at 3:38 PM, David Rees <dr...@gmail.com> wrote:
>> On Wed, Mar 30, 2011 at 10:22 AM, Igor Drobiazko
>> <ig...@gmail.com> wrote:
>>> Also this one is only fixed for 5.3.0:
>>>
>>> https://issues.apache.org/jira/browse/TAP5-1378
>>
>> I can confirm that TAP5-1378 is not fixed in 5.2.5. It's a show-stopper.
>>
>> Is the only way to get this fix to use 5.2-SNAPSHOT builds?
>>
>> I also don't see that the source for 5.2.5 was tagged anywhere.
>>
>> I would have expected to see that here:
>> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/
>>
>> I'm a bit confused as the ticket indicates that the changes were
>> committed to the 5.2-maint branch? If so - from what tree was the
>> 5.2.5 release built from? It's impossible to tell since the release
>> wasn't tagged.
>>
>> -Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by Kalle Korhonen <ka...@gmail.com>.
The tag is at http://svn.apache.org/repos/asf/tapestry/tapestry5/tags/releases/5.2.5/
Kalle
On Thu, Mar 31, 2011 at 3:38 PM, David Rees <dr...@gmail.com> wrote:
> On Wed, Mar 30, 2011 at 10:22 AM, Igor Drobiazko
> <ig...@gmail.com> wrote:
>> Also this one is only fixed for 5.3.0:
>>
>> https://issues.apache.org/jira/browse/TAP5-1378
>
> I can confirm that TAP5-1378 is not fixed in 5.2.5. It's a show-stopper.
>
> Is the only way to get this fix to use 5.2-SNAPSHOT builds?
>
> I also don't see that the source for 5.2.5 was tagged anywhere.
>
> I would have expected to see that here:
> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/
>
> I'm a bit confused as the ticket indicates that the changes were
> committed to the 5.2-maint branch? If so - from what tree was the
> 5.2.5 release built from? It's impossible to tell since the release
> wasn't tagged.
>
> -Dave
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP5-742: Fixed in 5.2.5?
Posted by Howard Lewis Ship <hl...@gmail.com>.
Code changes when to trunk, which was 5.3 at that time.
The Hudson job is poorly named, as it is now building 5.3. It really
should just say "trunk" not "5.x".
On Thu, Mar 31, 2011 at 3:38 PM, David Rees <dr...@gmail.com> wrote:
> On Wed, Mar 30, 2011 at 10:22 AM, Igor Drobiazko
> <ig...@gmail.com> wrote:
>> Also this one is only fixed for 5.3.0:
>>
>> https://issues.apache.org/jira/browse/TAP5-1378
>
> I can confirm that TAP5-1378 is not fixed in 5.2.5. It's a show-stopper.
>
> Is the only way to get this fix to use 5.2-SNAPSHOT builds?
>
> I also don't see that the source for 5.2.5 was tagged anywhere.
>
> I would have expected to see that here:
> http://svn.apache.org/viewvc/tapestry/tapestry5/tags/releases/
>
> I'm a bit confused as the ticket indicates that the changes were
> committed to the 5.2-maint branch? If so - from what tree was the
> 5.2.5 release built from? It's impossible to tell since the release
> wasn't tagged.
>
> -Dave
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org