You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/07/09 18:10:31 UTC
Re: Review Request 67757: TaskQuery struct needs to be optional
> On June 28, 2018, 11:23 a.m., Santhosh Kumar Shanmugham wrote:
> > Can you include the end-to-end test results? This takes about an hour to complete and can be invoked like so from the project root,
> >
> > ```
> > {~/oss/aurora} (master)$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> > ```
>
> Ezequiel Torres wrote:
> I've tried to execute the e2e tests but they seem to failed even from the master branch. I've uploaded the output of the test to the review. I'd really appretiate if someone could give some insight about the cause of the errors I'm seeing in the output.
>
> Kind Regards
> Ezequiel
>
> Santhosh Kumar Shanmugham wrote:
> Sorry. I am not able to find the output of the test in the review. Is this added as a file to the diff or in the testing section?
>
> Renan DelValle wrote:
> Unable to see the log file Ezequiel posted as well but I ran e2e tests locally with his patch locally and all tests passed.
>
> Ezequiel Torres wrote:
> Sorry guys, I forgot to hit the `publish` button after the file was uploaded. I think that you're going to be able to download it right now.
> Thanks Renan for running the e2e tests. Really appretiate it.
>
> Even though Renán said the tests passed, I'd really appretiate if you could throw some light on the output of the e2e file that I've uploaded to be able to run the tests on my own. I think it would be really helpful for future contributions to the project
>
> Kind Regards
> Ezequiel
Sorry for the delay. It looks like the end-to-end test was just flaky (I have seen it few times. You can vagrant destroy and recreate the VM to make sure to have clean start.). You should be able to retry it.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/#review205521
-----------------------------------------------------------
On June 29, 2018, 4:07 p.m., Ezequiel Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67757/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 4:07 p.m.)
>
>
> Review request for Aurora, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Bugs: https://issues.apache.org/jira/browse/AURORA-1991
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1991
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In languages like Go, types are not optionals by default.
> The actual api.thift don't let create queries with just a
> few fields in Go since all the fields are required
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
>
>
> Diff: https://reviews.apache.org/r/67757/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> End2End Output - branch master
> https://reviews.apache.org/media/uploaded/files/2018/06/29/22d45287-bbce-4603-b21b-e3ddd46cb178__branch_master_end2end_test_output.txt
>
>
> Thanks,
>
> Ezequiel Torres
>
>