You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2008/08/19 12:57:45 UTC
[jira] Created: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Manage credits for Base64OutputStream inclusion
-----------------------------------------------
Key: MIME4J-71
URL: https://issues.apache.org/jira/browse/MIME4J-71
Project: Mime4j
Issue Type: Task
Affects Versions: 0.4
Reporter: Stefano Bagnara
Priority: Blocker
Fix For: 0.5
I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
http://markmail.org/message/g6cqks56o6byu4fx
http://markmail.org/message/fv7njent2jg2whdz
http://markmail.org/message/cgf5ugtwcrr4fwcd
The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
-------------
Portions of this software were originally based on the following:
- software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
-------------
I didn't recognized this when I took the code at first, my bad!
Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Created: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by Stefano Bagnara <ap...@bago.org>.
David Jencks ha scritto:
> On Aug 19, 2008, at 3:57 AM, Stefano Bagnara (JIRA) wrote:
>
>> Manage credits for Base64OutputStream inclusion
>> -----------------------------------------------
>>
>> Key: MIME4J-71
>> URL: https://issues.apache.org/jira/browse/MIME4J-71
>> Project: Mime4j
>> Issue Type: Task
>> Affects Versions: 0.4
>> Reporter: Stefano Bagnara
>> Priority: Blocker
>> Fix For: 0.5
>>
>>
>> I want to add the fact that I'm investigating about the IPR for the
>> Base64OutputStream I introduced in the codebase some weeks ago.
>>
>> http://markmail.org/message/g6cqks56o6byu4fx
>> http://markmail.org/message/fv7njent2jg2whdz
>> http://markmail.org/message/cgf5ugtwcrr4fwcd
>>
>> The fact is that the package I used to get the Base64OutputStream has
>> a NOTICE including:
>> -------------
>> Portions of this software were originally based on the following:
>>
>> - software copyright (c) 2000-2006, Oracle Corp,
>> <http://www.oracle.com/>. and are licensed to the Apache Software
>> Foundation under the "Software Grant and Corporate Contribution
>> License Agreement"
>> -------------
>> I didn't recognized this when I took the code at first, my bad!
>>
>>
>> Credits have to be added to the main NOTICE.txt (used in main
>> distributions) and a solution have to be found for the NOTICE included
>> in jars (currently automatically added by maven with
>> apache-jar-resource-bundle:1.4 that does not support this scenario).
>
> Why can't you put the additional notice text in
> src/main/appended-resources/META-INF/NOTICE.vm in the appropriate
> project? This normally results in this text getting appended to the end
> of the text from the resource bundle. (hopefully I've remembered the
> file name correctly) This has worked for me in several places.
Thanks David! I didn't know that I could use appended-resources also for
this. I just found a discussion between you and Daniel Kulp about this
behaviour, I'll try it for sure! It's also interesting to note that
Daniel referred to the maven-shade-plugin used to merge NOTICEs
together.. interesting! I'll have to study this...
BTW I also prepared a new Base64OutputStream based on commons-codec
trunk Base64OutputStream (refactored a lot for our purpose) that is much
more performant, so maybe we'll simply dispose the Oracle's one and use
the ASF-only Base64OutputStream.
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Created: (MIME4J-71) Manage credits for Base64OutputStream inclusion
Posted by David Jencks <da...@yahoo.com>.
On Aug 19, 2008, at 3:57 AM, Stefano Bagnara (JIRA) wrote:
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
>
> I want to add the fact that I'm investigating about the IPR for the
> Base64OutputStream I introduced in the codebase some weeks ago.
>
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
>
> The fact is that the package I used to get the Base64OutputStream
> has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
>
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/
> >. and are licensed to the Apache Software Foundation under the
> "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
>
>
> Credits have to be added to the main NOTICE.txt (used in main
> distributions) and a solution have to be found for the NOTICE
> included in jars (currently automatically added by maven with apache-
> jar-resource-bundle:1.4 that does not support this scenario).
Why can't you put the additional notice text in src/main/appended-
resources/META-INF/NOTICE.vm in the appropriate project? This
normally results in this text getting appended to the end of the text
from the resource bundle. (hopefully I've remembered the file name
correctly) This has worked for me in several places.
thanks
david jencks
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Reopened: (MIME4J-71) Replace Base64OutputStream (Was:
Manage credits for Base64OutputStream inclusion)
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr reopened MIME4J-71:
-------------------------------------
Assignee: Markus Wiederkehr (was: Stefano Bagnara)
I have implemented a faster version of this class and added a few more unit tests. Also the Base64OutputStream now always terminates the output with exactly one CRLF (except if no data gets written at all).
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: JAMES Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Markus Wiederkehr
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-71:
----------------------------------
Attachment: Base64OutputStream2.java
Alternative implementation of Base64OutputStream.
This is based on Base64 + Base64OutputStream from the commons-codec svn trunk (Emmanuel Bourg suggested this) and refactored to be optimized for our usage (one single class, removed a couple of bytearray copies).
I run my old dummy performance check against the 3 implementation (Base64Encoder, Base64OutputStream from MyFaces, this Base64OutputStream2) and here are the results:
Base64Encoder: 2678ms
Base64OutputStream: 3160ms
Base64OutputStream2: 1954ms
very promising, I'd say.
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara resolved MIME4J-71.
-----------------------------------
Resolution: Fixed
Assignee: Stefano Bagnara
I removed the problematic code and reverted the NOTICE to not say anything.
Now we use a Base64OutputStream derived from original "3rd-party-credits-less" ASF code (commons-codec).
I would have used commons-codec as a dependency and maven-shade-plugin to shade that code in our release automatically (so to not fork the code) but I already changed too much in order to make it fit mime4j behaviours.
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-71) Replace Base64OutputStream (Was: Manage
credits for Base64OutputStream inclusion)
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr updated MIME4J-71:
------------------------------------
Attachment: (was: Base64OutputStreamSpeedTest.java)
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: JAMES Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Markus Wiederkehr
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64EncoderSpeedTest.java, Base64OutputStream2.java, Base64OutputStreamSpeedTest.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by "Emmanuel Bourg (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624065#action_12624065 ]
Emmanuel Bourg commented on MIME4J-71:
--------------------------------------
Nice performance improvement, do you think your optimization could be back ported to commons-codec or was it specific to mime4j?
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624275#action_12624275 ]
Stefano Bagnara commented on MIME4J-71:
---------------------------------------
@Emmanuel: I don't know what is the performance of commons-codec solution because I took Base64 and Base64OutputStream from commons-codec, merged them to a single class and started deleting anything that was not needed in an outputstream filter. Then I removed some arraycopy around that was superflous. I'm not sure how you could backport this to commons-codec if you want to keep the bytearray encoder separated from the outputstream wrapping it.
Please note that the timings above compare our current Base64OutputStream with the one I attacched here. I did not benchmark the commons-codec out-of-the-box solution at all.
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-71) Replace Base64OutputStream (Was: Manage
credits for Base64OutputStream inclusion)
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr updated MIME4J-71:
------------------------------------
Attachment: Base64EncoderSpeedTest.java
Base64OutputStreamSpeedTest.java
Performance tests for future reference
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: JAMES Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Markus Wiederkehr
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64EncoderSpeedTest.java, Base64OutputStream2.java, Base64OutputStreamSpeedTest.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-71) Replace Base64OutputStream (Was: Manage
credits for Base64OutputStream inclusion)
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-71:
----------------------------------
Summary: Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion) (was: Manage credits for Base64OutputStream inclusion)
Changed the title to reflect what actually happened.
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-71) Replace Base64OutputStream (Was: Manage
credits for Base64OutputStream inclusion)
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr updated MIME4J-71:
------------------------------------
Attachment: Base64OutputStreamSpeedTest.java
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: JAMES Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Markus Wiederkehr
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64EncoderSpeedTest.java, Base64OutputStream2.java, Base64OutputStreamSpeedTest.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-71) Manage credits for Base64OutputStream
inclusion
Posted by "Oleg Kalnichevski (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624344#action_12624344 ]
Oleg Kalnichevski commented on MIME4J-71:
-----------------------------------------
I am in favor of replacing the existing Base64OutputStream implementation with the alternative one based on commons-codec code.
+1 to commit
Oleg
> Manage credits for Base64OutputStream inclusion
> -----------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (MIME4J-71) Replace Base64OutputStream (Was:
Manage credits for Base64OutputStream inclusion)
Posted by "Markus Wiederkehr (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Markus Wiederkehr resolved MIME4J-71.
-------------------------------------
Resolution: Fixed
> Replace Base64OutputStream (Was: Manage credits for Base64OutputStream inclusion)
> ---------------------------------------------------------------------------------
>
> Key: MIME4J-71
> URL: https://issues.apache.org/jira/browse/MIME4J-71
> Project: JAMES Mime4j
> Issue Type: Task
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Markus Wiederkehr
> Priority: Blocker
> Fix For: 0.5
>
> Attachments: Base64OutputStream2.java
>
>
> I want to add the fact that I'm investigating about the IPR for the Base64OutputStream I introduced in the codebase some weeks ago.
> http://markmail.org/message/g6cqks56o6byu4fx
> http://markmail.org/message/fv7njent2jg2whdz
> http://markmail.org/message/cgf5ugtwcrr4fwcd
> The fact is that the package I used to get the Base64OutputStream has a NOTICE including:
> -------------
> Portions of this software were originally based on the following:
> - software copyright (c) 2000-2006, Oracle Corp, <http://www.oracle.com/>. and are licensed to the Apache Software Foundation under the "Software Grant and Corporate Contribution License Agreement"
> -------------
> I didn't recognized this when I took the code at first, my bad!
> Credits have to be added to the main NOTICE.txt (used in main distributions) and a solution have to be found for the NOTICE included in jars (currently automatically added by maven with apache-jar-resource-bundle:1.4 that does not support this scenario).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org