You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2019/01/28 06:49:08 UTC
Re: Review Request 69835: ATLAS-3036: Improve FullTextMapper
performance during entity retrieval (branch-0.8)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69835/#review212367
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 483 (original), 500 (patched)
<https://reviews.apache.org/r/69835/#comment298145>
for OBJECT_ID_TYPE attributes, 'ret' is populated only when 'includeReferences=true'; else 'ret' is set to true.
In case of ARRAY and MAP, soft-ref methods are not passed 'includeReferences' flag; so mapVertexToArrayForSoftRef() and mapVertexToMapForSoftRef() will return object-ids. Please review and make this consistent.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Line 579 (original), 596 (patched)
<https://reviews.apache.org/r/69835/#comment298146>
It will be efficient to bail out earlier, in case of includeReferences=false && isReferenceType(mapValueType).
Similarly review and update mapVertexToArray() as well.
- Madhan Neethiraj
On Jan. 24, 2019, 11:51 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69835/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2019, 11:51 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, madhan, Nikhil Bonte, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3036
> https://issues.apache.org/jira/browse/ATLAS-3036
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Improve FullTextMapper performance during entity retrieval
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java b4d399ad6
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java 84cd999ad
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java 549e595fb
>
>
> Diff: https://reviews.apache.org/r/69835/diff/1/
>
>
> Testing
> -------
>
> Validated throught REST API:
>
> "fullTextMapping": 60383 msecs (Before patch)
> "fullTextMapping": 20261 msecs (After patch)
>
>
> Thanks,
>
> Sarath Subramanian
>
>