You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/19 22:31:51 UTC

[Impala-ASF-CR] GUTIL: Pick parts of KUDU-2427 

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10769


Change subject: GUTIL: Pick parts of KUDU-2427
......................................................................

GUTIL: Pick parts of KUDU-2427

Pick parts of http://gerrit.cloudera.org:8080/10435 that are
required for KRPC.

These will be replaced with a proper rebase of gutil.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/sysinfo.cc
2 files changed, 41 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 16:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2803/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 16
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 02:34:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 17: Code-Review+2

Rebased, carrying Michael's +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 17
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 17:25:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG@11
PS14, Line 11: Rename constants
Can you please also specify the commit (e719b5ef) ?


http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc
File be/src/gutil/strings/substitute.cc:

http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc@15
PS14, Line 15: 
Is the change in gutil/strings/escaping.cc missing ?(https://github.com/apache/kudu/commit/e719b5eff2a47f61f9e6ee1f18d2055247f45847#diff-94c169876895d2a2b452a78355d51e57)



-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 14
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 18:51:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 17: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 17
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 07:33:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#6).

Change subject: Pick parts of recent Kudu gutil changes
......................................................................

Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/6
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] GUTIL: Pick parts of KUDU-2427

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: GUTIL: Pick parts of KUDU-2427
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10769/2/be/src/gutil/macros.h
File be/src/gutil/macros.h:

http://gerrit.cloudera.org:8080/#/c/10769/2/be/src/gutil/macros.h@265
PS2, Line 265: // Retry on EINTR for functions like read() that return -1 on error.
This is required to make syscalls more resilient to periodic interruptions when dumping stack traces.



-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 00:53:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#14).

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................

IMPALA-7006: Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/14
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 14
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 15: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2799/


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 15
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 01:19:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 15: Code-Review+2

Rebased and addressed the final comment, carrying Michael's +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 15
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 22:04:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#13).

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................

IMPALA-7006: Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/13
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 13
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] GUTIL: Pick parts of KUDU-2427

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#4).

Change subject: GUTIL: Pick parts of KUDU-2427
......................................................................

GUTIL: Pick parts of KUDU-2427

Pick parts of http://gerrit.cloudera.org:8080/10435 that are
required for KRPC.

These will be replaced with a proper rebase of gutil.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/sysinfo.cc
2 files changed, 41 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 14: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc
File be/src/gutil/strings/substitute.cc:

http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc@15
PS14, Line 15: 
> I only picked those parts of that commit that had an effect on Impala's cod
I see. Makes sense.



-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 14
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 21:45:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#12).

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................

IMPALA-7006: Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/12
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 12
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................

IMPALA-7006: Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants (Kudu commit e719b5ef)

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Reviewed-on: http://gerrit.cloudera.org:8080/10769
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 18
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 11:

This should be ready for review now.


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 11
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 20:17:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#15).

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................

IMPALA-7006: Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants (Kudu commit e719b5ef)

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/15
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 15
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10769/14//COMMIT_MSG@11
PS14, Line 11: Rename constants
> Can you please also specify the commit (e719b5ef) ?
Will do in final push.

  - Rename constants (Kudu commit e719b5ef)


http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc
File be/src/gutil/strings/substitute.cc:

http://gerrit.cloudera.org:8080/#/c/10769/14/be/src/gutil/strings/substitute.cc@15
PS14, Line 15: 
> Is the change in gutil/strings/escaping.cc missing ?(https://github.com/apa
I only picked those parts of that commit that had an effect on Impala's code, notably renaming NoArg to kNoArg. Parts that didn't affect Impala's inclusion of the Kudu code were left for a later, proper rebase of gutil.

Not picking this commit at all would have meant to undo parts of it in Kudu's code.



-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 14
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 21:14:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 17:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2804/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 17
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 04:11:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 )

Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes
......................................................................


Patch Set 15:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2799/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 15
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 22:05:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Pick parts of recent Kudu gutil changes

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10769

to look at the new patch set (#7).

Change subject: Pick parts of recent Kudu gutil changes
......................................................................

Pick parts of recent Kudu gutil changes

- Include some ASAN macros from gutil (Kudu commit c8724c61)
- Pick parts of KUDU-2427 (Kudu commit b7cf3b2e)
- Rename constants

These changes will be subsumed by a proper rebase of GUTIL.

Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
---
M be/src/gutil/macros.h
M be/src/gutil/port.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/sysinfo.cc
M be/src/util/error-util.h
6 files changed, 100 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/10769/7
-- 
To view, visit http://gerrit.cloudera.org:8080/10769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2dc8c70425e3ac030427ebeb1ec18a44d14d5cb
Gerrit-Change-Number: 10769
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>