You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/29 03:03:03 UTC
[GitHub] [doris] zhengshiJ opened a new pull request, #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
zhengshiJ opened a new pull request, #10481:
URL: https://github.com/apache/doris/pull/10481
# Proposed changes
Organize the plan process, improve the batch execution of rules and the way to add jobs.
Fix the problem that the condition in PhysicalHashJoin is empty.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhengshiJ commented on a diff in pull request #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
Posted by GitBox <gi...@apache.org>.
zhengshiJ commented on code in PR #10481:
URL: https://github.com/apache/doris/pull/10481#discussion_r910828405
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -94,16 +97,39 @@ public PhysicalPlan plan(LogicalPlan plan, PhysicalProperties outputProperties,
OptimizerContext optimizerContext = new OptimizerContext(memo);
plannerContext = new PlannerContext(optimizerContext, connectContext, outputProperties);
- plannerContext.getOptimizerContext().pushJob(
- new RewriteBottomUpJob(getRoot(), optimizerContext.getRuleSet().getAnalysisRules(), plannerContext));
-
- plannerContext.getOptimizerContext().pushJob(new OptimizeGroupJob(getRoot(), plannerContext));
- plannerContext.getOptimizerContext().getJobScheduler().executeJobPool(plannerContext);
-
// Get plan directly. Just for SSB.
+ return doPlan();
+ }
+
+ /**
+ * The actual execution of the plan, including the generation and execution of the job.
+ * @return PhysicalPlan.
+ */
+ private PhysicalPlan doPlan() {
+ List<Job> batchRuleJobs = addPlanJobs();
+ for (Job job : batchRuleJobs) {
+ plannerContext.getOptimizerContext().pushJob(job);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10481:
URL: https://github.com/apache/doris/pull/10481#discussion_r909483592
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -94,13 +92,21 @@ public PhysicalPlan plan(LogicalPlan plan, PhysicalProperties outputProperties,
OptimizerContext optimizerContext = new OptimizerContext(memo);
plannerContext = new PlannerContext(optimizerContext, connectContext, outputProperties);
- plannerContext.getOptimizerContext().pushJob(
- new RewriteBottomUpJob(getRoot(), optimizerContext.getRuleSet().getAnalysisRules(), plannerContext));
+ // Get plan directly. Just for SSB.
Review Comment:
this line comment should move to L110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10481:
URL: https://github.com/apache/doris/pull/10481#issuecomment-1169833364
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10481:
URL: https://github.com/apache/doris/pull/10481#discussion_r909186415
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -94,16 +97,39 @@ public PhysicalPlan plan(LogicalPlan plan, PhysicalProperties outputProperties,
OptimizerContext optimizerContext = new OptimizerContext(memo);
plannerContext = new PlannerContext(optimizerContext, connectContext, outputProperties);
- plannerContext.getOptimizerContext().pushJob(
- new RewriteBottomUpJob(getRoot(), optimizerContext.getRuleSet().getAnalysisRules(), plannerContext));
-
- plannerContext.getOptimizerContext().pushJob(new OptimizeGroupJob(getRoot(), plannerContext));
- plannerContext.getOptimizerContext().getJobScheduler().executeJobPool(plannerContext);
-
// Get plan directly. Just for SSB.
+ return doPlan();
+ }
+
+ /**
+ * The actual execution of the plan, including the generation and execution of the job.
+ * @return PhysicalPlan.
+ */
+ private PhysicalPlan doPlan() {
+ List<Job> batchRuleJobs = addPlanJobs();
+ for (Job job : batchRuleJobs) {
+ plannerContext.getOptimizerContext().pushJob(job);
Review Comment:
it is better to show the execute order is optimize job after analysis job explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10481: [feature](nereids) Adjust plan execution flow and fix physical bugs
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10481:
URL: https://github.com/apache/doris/pull/10481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org