You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2016/06/22 09:23:54 UTC

[GitHub] brooklyn-server pull request #213: TestSshCommand checks all assertions rath...

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/brooklyn-server/pull/213

    TestSshCommand checks all assertions rather than throwing first

    Fixes build by restoring behaviour changed in #212, which broke `TestSshCommandTest.shouldNotBeUpIfAssertionsFail` because only one failure was in the exception message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-server repeat-ssh-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit c6266dde407756b93a06e037928371bd30f944ca
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-06-22T09:22:28Z

    TestSshCommand checks all assertions rather than throwing first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #213: TestSshCommand checks all assertions rath...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #213: TestSshCommand checks all assertions rath...

Posted by sjcorbett <gi...@git.apache.org>.
GitHub user sjcorbett reopened a pull request:

    https://github.com/apache/brooklyn-server/pull/213

    TestSshCommand checks all assertions rather than throwing first

    Fixes build by restoring behaviour changed in #212, which broke `TestSshCommandTest.shouldNotBeUpIfAssertionsFail` because only one failure was in the exception message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-server repeat-ssh-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit c6266dde407756b93a06e037928371bd30f944ca
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-06-22T09:22:28Z

    TestSshCommand checks all assertions rather than throwing first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #213: TestSshCommand checks all assertions rather than...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/213
  
    Jenkins failure: `java.lang.OutOfMemoryError: unable to create new native thread`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #213: TestSshCommand checks all assertions rath...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #213: TestSshCommand checks all assertions rather than...

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/213
  
    Going to merge this since it fixes the build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---