You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/01 07:29:43 UTC
[GitHub] [flink] danny0405 opened a new pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
danny0405 opened a new pull request #13293:
URL: https://github.com/apache/flink/pull/13293
…d by the system with 'EXPR$' prefix
## What is the purpose of the change
For query
```sql
create view tmp_view as
select * from (
select f0,
row_number() over (partition by f0 order by f0 desc) as rowNum
from source) -- the query would be aliased as "EXPR$1"
where rowNum = 1
```
When validation, the inner query would have alias assigned by the system with prefix "EXPR$1", when in the `Expander`, we replace the id in the inner query all with this prefix which is wrong because we do not add the alias to the inner query anymore.
To solve the problem, skip the expanding of id with "EXPR$" just like how SqlUtil#deriveAliasFromOrdinal added it.
This was introduced by FLINK-18750.
## Brief change log
- Add fix in `Expander` and add tests
## Verifying this change
Added UT.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not documented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13293:
URL: https://github.com/apache/flink/pull/13293#issuecomment-684526091
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6046",
"triggerID" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0524b7153e6a3b04a1dd84c4a98f84a06837f75 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6046)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13293:
URL: https://github.com/apache/flink/pull/13293#issuecomment-684516967
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b0524b7153e6a3b04a1dd84c4a98f84a06837f75 (Tue Sep 01 07:34:37 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19108).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13293:
URL: https://github.com/apache/flink/pull/13293#issuecomment-684526091
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0524b7153e6a3b04a1dd84c4a98f84a06837f75 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13293:
URL: https://github.com/apache/flink/pull/13293#issuecomment-684526091
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6046",
"triggerID" : "b0524b7153e6a3b04a1dd84c4a98f84a06837f75",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0524b7153e6a3b04a1dd84c4a98f84a06837f75 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6046)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #13293: [FLINK-19108][table] Stop expanding the identifiers with scope aliase…
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #13293:
URL: https://github.com/apache/flink/pull/13293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org