[jira] [Commented] (SAMZA-930) samza-autoscaling YarnUtils json deserialisation fails with list values

["Jake Maes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241435#comment-15241435 ] 

Jake Maes commented on SAMZA-930:
---------------------------------

Hey [~alex.buck10], it looks like the RB link is missing. The patch needs to be reviewed before it will get committed. 
http://samza.apache.org/contribute/rules.html

> samza-autoscaling YarnUtils json deserialisation fails with list values
> -----------------------------------------------------------------------
>
>                 Key: SAMZA-930
>                 URL: https://issues.apache.org/jira/browse/SAMZA-930
>             Project: Samza
>          Issue Type: Bug
>    Affects Versions: 0.10.1
>            Reporter: Alex Buck
>            Assignee: Alex Buck
>         Attachments: samza-930.patch
>
>
> Current:
> The {{getRunningAppId}} method in {{org.apache.samza.autoscaling.utils.YarnUtil}} attempts to deserialise the json from this endpoint {{/ws/v1/cluster/apps}} on the resource manager into the following shape: {{<Map<String, Map<String, List<Map<String, String>>>>>}}
> The problem is that when there is a running job there is a property called {{resourceRequests}} which has a json array as a value. Therefore Jackson throws an exception when it tries to deserialise a json array into a string.
> Proposed:
> Deserialise the json into the following structure: {{<Map<String, Map<String, List<Map<String, Object>>>>>}}. The only property being queried for is the `state` so I think this is appropiate.
> I have written the first test for this module. Very open to feedback and improvements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)