You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/14 18:47:20 UTC
[kudu-CR] macOS: disable pstack watcher-test
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5071
Change subject: macOS: disable pstack_watcher-test
......................................................................
macOS: disable pstack_watcher-test
pstack_watcher does not work correctly on macOS, since it's much harder
to get user thread stacks.
Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
---
M src/kudu/util/CMakeLists.txt
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/5071/1
--
To view, visit http://gerrit.cloudera.org:8080/5071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR] macOS: disable pstack watcher-test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: macOS: disable pstack_watcher-test
......................................................................
Patch Set 1: Code-Review+2
Could you remind me why this was preferable to disabling pstack_watcher.cc entirely?
--
To view, visit http://gerrit.cloudera.org:8080/5071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] macOS: disable pstack watcher-test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: macOS: disable pstack_watcher-test
......................................................................
macOS: disable pstack_watcher-test
pstack_watcher does not work correctly on macOS, since it's much harder
to get user thread stacks.
Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
Reviewed-on: http://gerrit.cloudera.org:8080/5071
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/CMakeLists.txt
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] macOS: disable pstack watcher-test
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: macOS: disable pstack_watcher-test
......................................................................
Patch Set 1:
It's significantly less intrusive, basically. I'm also of the opinion that the log output is useful as a binary present/not present, even if it doesn't have the actual stack trace.
--
To view, visit http://gerrit.cloudera.org:8080/5071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd88c96f32ccc0e8eadf25e38f8e5693d1081fbb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No