You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Paul Ramirez (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 18:56:49 UTC
[jira] [Created] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Remove Embedded Optimize from Lucene Workflow Instance Repository
-----------------------------------------------------------------
Key: OODT-390
URL: https://issues.apache.org/jira/browse/OODT-390
Project: OODT
Issue Type: Improvement
Components: workflow manager
Affects Versions: 0.3
Reporter: Paul Ramirez
Assignee: Paul Ramirez
Fix For: 0.4
Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229333#comment-13229333 ]
jiraposter@reviews.apache.org commented on OODT-390:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4053/#review5949
-----------------------------------------------------------
Ship it!
- Ricky
On 2012-02-27 18:04:21, Paul Ramirez wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4053/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 18:04:21)
bq.
bq.
bq. Review request for Chris Mattmann, brian Foster and Ricky Nguyen.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The optimize function can be time consuming depending on the size of the index. It was externalized in the file manager as a tool for just this reason; which can be reuse here for optimizing. This change then boils down to removing the call to optimize every time a workflow instance was added to the repository. In theory this could help speed things up for people using this type of instance repository.
bq.
bq.
bq. This addresses bug OODT-390.
bq. https://issues.apache.org/jira/browse/OODT-390
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepository.java 1294242
bq.
bq. Diff: https://reviews.apache.org/r/4053/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Paul
bq.
bq.
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "Paul Ramirez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Ramirez resolved OODT-390.
-------------------------------
Resolution: Fixed
Committed revision 1378589.
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.5
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229480#comment-13229480 ]
jiraposter@reviews.apache.org commented on OODT-390:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4053/#review5955
-----------------------------------------------------------
Ship it!
Yeah buddy looks good!
- Chris
On 2012-02-27 18:04:21, Paul Ramirez wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4053/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 18:04:21)
bq.
bq.
bq. Review request for Chris Mattmann, brian Foster and Ricky Nguyen.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The optimize function can be time consuming depending on the size of the index. It was externalized in the file manager as a tool for just this reason; which can be reuse here for optimizing. This change then boils down to removing the call to optimize every time a workflow instance was added to the repository. In theory this could help speed things up for people using this type of instance repository.
bq.
bq.
bq. This addresses bug OODT-390.
bq. https://issues.apache.org/jira/browse/OODT-390
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepository.java 1294242
bq.
bq. Diff: https://reviews.apache.org/r/4053/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Paul
bq.
bq.
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217336#comment-13217336 ]
jiraposter@reviews.apache.org commented on OODT-390:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4053/
-----------------------------------------------------------
Review request for Chris Mattmann, brian Foster and Ricky Nguyen.
Summary
-------
The optimize function can be time consuming depending on the size of the index. It was externalized in the file manager as a tool for just this reason; which can be reuse here for optimizing. This change then boils down to removing the call to optimize every time a workflow instance was added to the repository. In theory this could help speed things up for people using this type of instance repository.
This addresses bug OODT-390.
https://issues.apache.org/jira/browse/OODT-390
Diffs
-----
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepository.java 1294242
Diff: https://reviews.apache.org/r/4053/diff
Testing
-------
Thanks,
Paul
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217342#comment-13217342 ]
jiraposter@reviews.apache.org commented on OODT-390:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4053/#review5356
-----------------------------------------------------------
Ship it!
Looks good to me.
- Chris
On 2012-02-27 18:04:21, Paul Ramirez wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4053/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 18:04:21)
bq.
bq.
bq. Review request for Chris Mattmann, brian Foster and Ricky Nguyen.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The optimize function can be time consuming depending on the size of the index. It was externalized in the file manager as a tool for just this reason; which can be reuse here for optimizing. This change then boils down to removing the call to optimize every time a workflow instance was added to the repository. In theory this could help speed things up for people using this type of instance repository.
bq.
bq.
bq. This addresses bug OODT-390.
bq. https://issues.apache.org/jira/browse/OODT-390
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepository.java 1294242
bq.
bq. Diff: https://reviews.apache.org/r/4053/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Paul
bq.
bq.
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OODT-390) Remove Embedded Optimize from Lucene
Workflow Instance Repository
Posted by "Paul Ramirez (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Ramirez updated OODT-390:
------------------------------
Attachment: oodt-390-patch.txt
One liner removal.
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
> Key: OODT-390
> URL: https://issues.apache.org/jira/browse/OODT-390
> Project: OODT
> Issue Type: Improvement
> Components: workflow manager
> Affects Versions: 0.3
> Reporter: Paul Ramirez
> Assignee: Paul Ramirez
> Fix For: 0.4
>
> Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for lucene. This functionality should be relegated to an external tool as was done with the lucene file manager catalog. That tool can actually be reused to optimize this index. Calling optimize on the index on each add could cause some performance issues and making this an external function should rectify that. If one is working in a system where they have large batches they should run the optimize tool when the see degradation or on a semi-regular basis.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira