You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/28 15:37:34 UTC

[GitHub] [maven] bmarwell edited a comment on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

bmarwell edited a comment on pull request #415:
URL: https://github.com/apache/maven/pull/415#issuecomment-751754398


   > This looks OK, but incomplete. When if you at `org.apache.maven.cli.MavenCli.logging(CliRequest)` in the block marked with `// LOG COLOR` you see duplicate code now. It is probably time to move that code out of `logging()` into `cli()`.
   
   Which one? This? 
   https://github.com/apache/maven/blob/496b9bd65d0ddd0fb19c8c9f89058555f458790e/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L508-L522
   
   I do not see this code duplicated somewhere else. There are other duplicated parts, however.
   
   ![2020-12-28T16:35:36_0001_screenshot](https://user-images.githubusercontent.com/1413391/103225713-dcfdb280-492a-11eb-8544-fced0e35043a.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org