[GitHub] [samza] prateekm commented on a change in pull request #1429: SAMZA-2591: API updates for TaskStorageBackupManager

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1429:
URL: https://github.com/apache/samza/pull/1429#discussion_r585905942



##########
File path: samza-api/src/main/java/org/apache/samza/storage/TaskBackupManager.java
##########
@@ -60,10 +61,12 @@ default void start(Checkpoint checkpoint) {}
    * @param stateCheckpointMarkers The map of storename to checkpoint makers returned by the snapshot
    * @return The future of storename to checkpoint map of the uploaded local store
    */
-  CompletableFuture<Map<String, StateCheckpointMarker>> upload(CheckpointId checkpointId, Map<String, StateCheckpointMarker> stateCheckpointMarkers);
+  CompletableFuture<Map<String, StateCheckpointMarker>> upload(CheckpointId checkpointId,
+      Map<String, StateCheckpointMarker> stateCheckpointMarkers);
 
   /**
-   * Persist the state locally to the file system
+   * Occurs after the state has been persisted. Writes a copy of the persisted StateCheckpointMarkers from

Review comment:
       Should this be called independently by each storage backend (resulting in many different "OFFSET-V2" equivalent files), or should this be called once by TaskInstance / TaskCommitManager after collecting all the inputOffsets and SCMs and creating the checkpoint?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org