You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Florian Wunderlich (JIRA)" <ji...@apache.org> on 2010/08/19 10:41:15 UTC
[jira] Created: (WICKET-3003) Form.delegateSubmit: invoke
onSubmit() of nested Forms before onSubmit() of enclosing Form
Form.delegateSubmit: invoke onSubmit() of nested Forms before onSubmit() of enclosing Form
------------------------------------------------------------------------------------------
Key: WICKET-3003
URL: https://issues.apache.org/jira/browse/WICKET-3003
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4.10
Reporter: Florian Wunderlich
Priority: Minor
As has been discussed on the mailing list:
http://mail-archives.apache.org/mod_mbox/wicket-dev/201008.mbox/<AA...@mail.gmail.com>
It can be assumed that an enclosing Form in some way or another may depend on the state of an enclosed Form, but that an enclosed Form should never depend on the state of its enclosing Form.
Therefore, Form.delegateSubmit should invoke onSubmit() of the nested Forms, depth first, before invoking onSubmit() of the enclosing Form. At the moment, this is the other way around.
The attached patch rectifies this situation. Please review and apply if so desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3003) Form.delegateSubmit: invoke
onSubmit() of nested Forms before onSubmit() of enclosing Form
Posted by "Florian Wunderlich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Wunderlich updated WICKET-3003:
---------------------------------------
Attachment: nested-form-onsubmit.patch
> Form.delegateSubmit: invoke onSubmit() of nested Forms before onSubmit() of enclosing Form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3003
> URL: https://issues.apache.org/jira/browse/WICKET-3003
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.10
> Reporter: Florian Wunderlich
> Priority: Minor
> Attachments: nested-form-onsubmit.patch
>
>
> As has been discussed on the mailing list:
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201008.mbox/<AA...@mail.gmail.com>
> It can be assumed that an enclosing Form in some way or another may depend on the state of an enclosed Form, but that an enclosed Form should never depend on the state of its enclosing Form.
> Therefore, Form.delegateSubmit should invoke onSubmit() of the nested Forms, depth first, before invoking onSubmit() of the enclosing Form. At the moment, this is the other way around.
> The attached patch rectifies this situation. Please review and apply if so desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3003) Form.delegateSubmit: invoke
onSubmit() of nested Forms before onSubmit() of enclosing Form
Posted by "Florian Wunderlich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900219#action_12900219 ]
Florian Wunderlich commented on WICKET-3003:
--------------------------------------------
I would argue that this patch is fit for inclusion in the production branch, because it fixes a bug that no application should rely on.
> Form.delegateSubmit: invoke onSubmit() of nested Forms before onSubmit() of enclosing Form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3003
> URL: https://issues.apache.org/jira/browse/WICKET-3003
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.10
> Reporter: Florian Wunderlich
> Priority: Minor
> Attachments: nested-form-onsubmit.patch
>
>
> As has been discussed on the mailing list:
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201008.mbox/<AA...@mail.gmail.com>
> It can be assumed that an enclosing Form in some way or another may depend on the state of an enclosed Form, but that an enclosed Form should never depend on the state of its enclosing Form.
> Therefore, Form.delegateSubmit should invoke onSubmit() of the nested Forms, depth first, before invoking onSubmit() of the enclosing Form. At the moment, this is the other way around.
> The attached patch rectifies this situation. Please review and apply if so desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3003) Form.delegateSubmit: invoke
onSubmit() of nested Forms before onSubmit() of enclosing Form
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900936#action_12900936 ]
Hudson commented on WICKET-3003:
--------------------------------
Integrated in Apache Wicket 1.5.x #252 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/252/])
> Form.delegateSubmit: invoke onSubmit() of nested Forms before onSubmit() of enclosing Form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3003
> URL: https://issues.apache.org/jira/browse/WICKET-3003
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.10
> Reporter: Florian Wunderlich
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M2
>
> Attachments: nested-form-onsubmit.patch
>
>
> As has been discussed on the mailing list:
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201008.mbox/<AA...@mail.gmail.com>
> It can be assumed that an enclosing Form in some way or another may depend on the state of an enclosed Form, but that an enclosed Form should never depend on the state of its enclosing Form.
> Therefore, Form.delegateSubmit should invoke onSubmit() of the nested Forms, depth first, before invoking onSubmit() of the enclosing Form. At the moment, this is the other way around.
> The attached patch rectifies this situation. Please review and apply if so desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3003) Form.delegateSubmit: invoke
onSubmit() of nested Forms before onSubmit() of enclosing Form
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3003.
-----------------------------------
Assignee: Igor Vaynberg
Fix Version/s: 1.5-M2
Resolution: Fixed
not fixing in 1.4.x. its not a matter of whether or not clients *should* depend on this bug, its a matter of whether or not they do. unfortunately that precludes as from fixing this in 1.4.x.
the good news is that nothing is set in stone, you are welcome to start a vote on the user list and if no one objects to this being fixed in 1.4.x we will.
> Form.delegateSubmit: invoke onSubmit() of nested Forms before onSubmit() of enclosing Form
> ------------------------------------------------------------------------------------------
>
> Key: WICKET-3003
> URL: https://issues.apache.org/jira/browse/WICKET-3003
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.10
> Reporter: Florian Wunderlich
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M2
>
> Attachments: nested-form-onsubmit.patch
>
>
> As has been discussed on the mailing list:
> http://mail-archives.apache.org/mod_mbox/wicket-dev/201008.mbox/<AA...@mail.gmail.com>
> It can be assumed that an enclosing Form in some way or another may depend on the state of an enclosed Form, but that an enclosed Form should never depend on the state of its enclosing Form.
> Therefore, Form.delegateSubmit should invoke onSubmit() of the nested Forms, depth first, before invoking onSubmit() of the enclosing Form. At the moment, this is the other way around.
> The attached patch rectifies this situation. Please review and apply if so desired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.