You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2014/11/03 22:53:44 UTC
Review Request 27540: AMBARI-8120 - Configs tab doesn't appear for all
services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/
-----------------------------------------------------------
Review request for Ambari, Florian Barca, Jayush Luniya, and Mahadev Konar.
Bugs: AMBARI-8120
https://issues.apache.org/jira/browse/AMBARI-8120
Repository: ambari
Description
-------
AMBARI-8120 - Configs tab doesn't appear for all services
Diffs
-----
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
ambari-web/app/controllers/main/service/info/configs.js c9ec483
ambari-web/app/utils/ajax/ajax.js f264dc4
Diff: https://reviews.apache.org/r/27540/diff/
Testing
-------
[INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review60803
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On Nov. 4, 2014, 7:36 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:36 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
> On Лис. 4, 2014, 8:04 після полудня, Jayush Luniya wrote:
> > ambari-web/app/controllers/main/service/info/configs.js, line 262
> > <https://reviews.apache.org/r/27540/diff/1/?file=747797#file747797line262>
> >
> > Can you also add error callback loadClusterEnvSiteError?
Basically if we do not specify error handler function for App.ajax, the default handler will be used (defaultErrorHandler from ambari-web/app/utils/ajax/ajax.js). It shows alert popup with error details from request response. So as we don't need any specific logic to handle errors I just skip custom error handler. But if we need some specific logic to handle errors, I can add custom handler.
- Aleksandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review59817
-----------------------------------------------------------
On Лис. 4, 2014, 7:36 після полудня, Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Лис. 4, 2014, 7:36 після полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review59817
-----------------------------------------------------------
ambari-web/app/controllers/main/service/info/configs.js
<https://reviews.apache.org/r/27540/#comment101115>
Can you also add error callback loadClusterEnvSiteError?
- Jayush Luniya
On Nov. 4, 2014, 7:36 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:36 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review63124
-----------------------------------------------------------
@Artem
Can you close this review?
- Jayush Luniya
On Nov. 4, 2014, 7:36 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:36 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review60198
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Nov. 4, 2014, 7:36 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 7:36 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/
-----------------------------------------------------------
(Updated Ноя. 4, 2014, 7:36 п.п.)
Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
Bugs: AMBARI-8120
https://issues.apache.org/jira/browse/AMBARI-8120
Repository: ambari
Description
-------
AMBARI-8120 - Configs tab doesn't appear for all services
Diffs
-----
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
ambari-web/app/controllers/main/service/info/configs.js c9ec483
ambari-web/app/utils/ajax/ajax.js f264dc4
Diff: https://reviews.apache.org/r/27540/diff/
Testing
-------
[INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
> On Лис. 4, 2014, 7:06 після полудня, Florian Barca wrote:
> >
It is just mock json data for test mode. We use test mode on local machines to run ambari web without ambari server (with mock data). As you can see in other json files (any file in ambari\ambari-web\app\assets\data) we commonly use the full equivalent of real server response including host name. It realy does not matter what host name is used for href in json files.
- Aleksandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review59797
-----------------------------------------------------------
On Лис. 4, 2014, 7:36 після полудня, Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Лис. 4, 2014, 7:36 після полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Artem Baranchuk <ab...@hortonworks.com>.
> On Ноя. 4, 2014, 7:06 п.п., Florian Barca wrote:
> > ambari-web/app/assets/data/configuration/cluster_env_site.json, line 2
> > <https://reviews.apache.org/r/27540/diff/1/?file=747796#file747796line2>
> >
> > Would it be possible to avoid exposing what looks lik test host names? Maybe parameterize them. Applies to row 5 too.
Alex could you please ansver this question?
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review59797
-----------------------------------------------------------
On Ноя. 4, 2014, 7:36 п.п., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Ноя. 4, 2014, 7:36 п.п.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 27540: AMBARI-8120 - Configs tab doesn't appear
for all services
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27540/#review59797
-----------------------------------------------------------
ambari-web/app/assets/data/configuration/cluster_env_site.json
<https://reviews.apache.org/r/27540/#comment101102>
Would it be possible to avoid exposing what looks lik test host names? Maybe parameterize them. Applies to row 5 too.
- Florian Barca
On Nov. 3, 2014, 9:53 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27540/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2014, 9:53 p.m.)
>
>
> Review request for Ambari, Florian Barca, Jayush Luniya, and Mahadev Konar.
>
>
> Bugs: AMBARI-8120
> https://issues.apache.org/jira/browse/AMBARI-8120
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-8120 - Configs tab doesn't appear for all services
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml 8e909bc
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml 31eb346
> ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION
> ambari-web/app/controllers/main/service/info/configs.js c9ec483
> ambari-web/app/utils/ajax/ajax.js f264dc4
>
> Diff: https://reviews.apache.org/r/27540/diff/
>
>
> Testing
> -------
>
> [INFO] Ambari Server ..................................... SUCCESS [28:51.093s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>