You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/04/12 23:44:54 UTC
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6616
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Fixes the HS2 timeouts for _all_ Kudu EE tests. Previously
only 2 classes had the timeout set, but all the Kudu tests
appear to be susceptible to this issue.
Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
---
M tests/common/kudu_test_suite.py
M tests/query_test/test_kudu.py
2 files changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/6616/1
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/451/
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1:
Yeah, it's a good question. I don't know and unfortunately I think it's more general than the Kudu tests, we've seen these errors pop up in other places when using this HS2 client in the test code.
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Fixes the HS2 timeouts for _all_ Kudu EE tests. Previously
only 2 classes had the timeout set, but all the Kudu tests
appear to be susceptible to this issue.
Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Reviewed-on: http://gerrit.cloudera.org:8080/6616
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/common/kudu_test_suite.py
M tests/query_test/test_kudu.py
2 files changed, 5 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, but someone else must approve
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1:
> Uploaded patch set 1.
Do we know why some Kudu operations take so long, and if that's expected behavior?
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts
......................................................................
Patch Set 1: Code-Review+2
I think we should check this in to stabilize the builds. Still, Sailesh has a good point. We should figure out why the operations take so long.
--
To view, visit http://gerrit.cloudera.org:8080/6616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc48b4b7ae65ddf4bba087d079d4e4032f4d5f0f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No