You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-db (via GitHub)" <gi...@apache.org> on 2025/07/29 23:06:29 UTC
[PR] [SPARK-51555][SQL] Add the timediff() function [spark]
uros-db opened a new pull request, #51715:
URL: https://github.com/apache/spark/pull/51715
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Implement the `timediff` function, which returns the difference between two times measured in units.
Syntax
```
timediff(unit, start, end)
unit
{ MICROSECOND |
MILLISECOND |
SECOND |
MINUTE |
HOUR }
```
Arguments
- `unit`: A unit of measure.
- `start`: A starting TIME expression.
- `end`: An ending TIME expression.
Returns
An INTEGER.
If start is greater than end the result is negative.
### Why are the changes needed?
Users will be able to calculate time difference in specified units.
### Does this PR introduce _any_ user-facing change?
Yes, this PR introduces a new expression.
### How was this patch tested?
New unit tests for time truncation, catalyst expression level unit tests with & without codegen, e2e SQL tests / golden files in both ANSI and non-ANSI modes.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51555][SQL] Add the time_diff() function [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #51715:
URL: https://github.com/apache/spark/pull/51715#issuecomment-3138665551
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51555][SQL] Add the time_diff() function [spark]
Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #51715:
URL: https://github.com/apache/spark/pull/51715#discussion_r2242723915
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala:
##########
@@ -716,6 +716,43 @@ object DateTimeUtils extends SparkDateTimeUtils {
(endNanos - startNanos) / NANOS_PER_MICROS
}
+ // Helper method to get the number of nanoseconds per the given time unit, used for calculating
+ // the difference between two time values (timediff function). Supported units are: MICROSECOND,
+ // MILLISECOND, SECOND, MINUTE, HOUR.
+ private def getNanosPerTimeUnit(unit: UTF8String): Long = {
+ val unitStr = unit.toString
+ unitStr.toUpperCase(Locale.ROOT) match {
+ case "MICROSECOND" =>
+ NANOS_PER_MICROS
+ case "MILLISECOND" =>
+ NANOS_PER_MILLIS
+ case "SECOND" =>
+ NANOS_PER_SECOND
+ case "MINUTE" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE
+ case "HOUR" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE * MINUTES_PER_HOUR
+ case _ =>
+ throw QueryExecutionErrors.invalidTimeUnitError("timediff", unitStr)
+ }
+ }
+
+ /**
+ * Gets the difference between two time values in the specified unit.
+ *
+ * @param unit Specifies the interval units in which to express the difference between
+ * the two time parameters. Supported units are: MICROSECOND, MILLISECOND,
+ * SECOND, MINUTE, HOUR.
+ * @param startNanos A time value expressed as nanoseconds since the start of the day,
+ * which the function subtracts from `endNanos`.
+ * @param endNanos A time value expressed as nanoseconds since the start of the day,
+ * from which the function subtracts `startNanos`.
+ * @return The time span between two time values, in the units specified.
+ */
+ def timeDiff(unit: UTF8String, startNanos: Long, endNanos: Long): Long = {
+ (endNanos - startNanos) / getNanosPerTimeUnit(unit)
Review Comment:
Not for valid time input (nanos between 00:00:00 and 23:59:59.999999999).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51555][SQL] Add the time_diff() function [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51715:
URL: https://github.com/apache/spark/pull/51715#discussion_r2242658809
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala:
##########
@@ -716,6 +716,43 @@ object DateTimeUtils extends SparkDateTimeUtils {
(endNanos - startNanos) / NANOS_PER_MICROS
}
+ // Helper method to get the number of nanoseconds per the given time unit, used for calculating
+ // the difference between two time values (timediff function). Supported units are: MICROSECOND,
+ // MILLISECOND, SECOND, MINUTE, HOUR.
+ private def getNanosPerTimeUnit(unit: UTF8String): Long = {
+ val unitStr = unit.toString
+ unitStr.toUpperCase(Locale.ROOT) match {
+ case "MICROSECOND" =>
+ NANOS_PER_MICROS
+ case "MILLISECOND" =>
+ NANOS_PER_MILLIS
+ case "SECOND" =>
+ NANOS_PER_SECOND
+ case "MINUTE" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE
+ case "HOUR" =>
+ NANOS_PER_SECOND * SECONDS_PER_MINUTE * MINUTES_PER_HOUR
+ case _ =>
+ throw QueryExecutionErrors.invalidTimeUnitError("timediff", unitStr)
+ }
+ }
+
+ /**
+ * Gets the difference between two time values in the specified unit.
+ *
+ * @param unit Specifies the interval units in which to express the difference between
+ * the two time parameters. Supported units are: MICROSECOND, MILLISECOND,
+ * SECOND, MINUTE, HOUR.
+ * @param startNanos A time value expressed as nanoseconds since the start of the day,
+ * which the function subtracts from `endNanos`.
+ * @param endNanos A time value expressed as nanoseconds since the start of the day,
+ * from which the function subtracts `startNanos`.
+ * @return The time span between two time values, in the units specified.
+ */
+ def timeDiff(unit: UTF8String, startNanos: Long, endNanos: Long): Long = {
+ (endNanos - startNanos) / getNanosPerTimeUnit(unit)
Review Comment:
is there a risk of overflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51555][SQL] Add the time_diff() function [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #51715: [SPARK-51555][SQL] Add the time_diff() function
URL: https://github.com/apache/spark/pull/51715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org