You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/11/09 21:26:32 UTC

[GitHub] [hbase] taklwu commented on pull request #3823: HBASE-26432 enable tracing from shell

taklwu commented on pull request #3823:
URL: https://github.com/apache/hbase/pull/3823#issuecomment-964562435


   https://github.com/apache/hbase/blob/8ce7b92ff540736c9ceefd86dd1d9f142454bb45/hbase-shell/src/main/ruby/shell/commands/trace.rb#L29
   
   above line should reaplace HTrace to OpenTelemetry 
   
   
   https://github.com/apache/hbase/blob/8ce7b92ff540736c9ceefd86dd1d9f142454bb45/hbase-shell/src/main/ruby/shell/commands/trace.rb#L33
   
   [nit] I personally don't want the stop to return `false` if it's success, but I'm not sure if we should change the behavior 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org