[GitHub] gaborgsomogyi commented on a change in pull request #23142: [SPARK-26170][SS] Add missing metrics in FlatMapGroupsWithState

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #23142: [SPARK-26170][SS] Add missing metrics in FlatMapGroupsWithState
URL: https://github.com/apache/spark/pull/23142#discussion_r241707706
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FlatMapGroupsWithStateExec.scala
 ##########
 @@ -111,28 +111,41 @@ case class FlatMapGroupsWithStateExec(
       indexOrdinal = None,
       sqlContext.sessionState,
       Some(sqlContext.streams.stateStoreCoordinator)) { case (store, iter) =>
+        val numOutputRows = longMetric("numOutputRows")
 
 Review comment:
   Just wondering what's the difference between this and the metric with the same name in `InputProcessor`? Don't they collide somehow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org