You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2021/08/01 13:56:14 UTC
[GitHub] [incubator-livy] WinkerDu opened a new pull request #325: [LIVY-865][SERVER] Fix bug that Livy identifies valid yarn state of batch session as FAILED
WinkerDu opened a new pull request #325:
URL: https://github.com/apache/incubator-livy/pull/325
## What changes were proposed in this pull request?
yarnClient.getApplicationReport(appId) would return 2 states below:
1. YarnApplicationState (short as yarnState)
2. FinalApplicationStatus (short as finalState)
These 2 states may switch sequentially in practice, means (yarnState, finalState) as
(RUNNING, SUCCEEDED) would switch to (FINISHED, SUCCEEDED) finally.
For now, (yarnState, finalState) as (RUNNING, SUCCEEDED) would be identified as `FAILED` state combination
This PR introduce new logic to map yarn state combination as bellow:
1. yarnState as NEW、NEW_SAVING、SUBMITTED、ACCEPTED would be identified as `STARTING`
2. yarnState as RUNNING would be identified as `RUNNING`
3. other yarnState and finalState combinations would be identified to rules:
- (FAILED, FAILED) -> `FAILED`
- (KILLED, KILLED) -> `KILLED`
- (FINISHED, SUCCEEDED) -> `FINISHED`
- any other combination -> `FAILED`
## How was this patch tested?
added UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] WinkerDu commented on pull request #325: [LIVY-865][SERVER] Fix bug that Livy identifies valid yarn state of batch session as FAILED
Posted by GitBox <gi...@apache.org>.
WinkerDu commented on pull request #325:
URL: https://github.com/apache/incubator-livy/pull/325#issuecomment-891034770
> I am not familiar with this part, sorry
@mgaido91 thx for the reply, can you introduce any reviewer familiar with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] WinkerDu commented on pull request #325: [LIVY-865][SERVER] Fix bug that Livy identifies valid yarn state of batch session as FAILED
Posted by GitBox <gi...@apache.org>.
WinkerDu commented on pull request #325:
URL: https://github.com/apache/incubator-livy/pull/325#issuecomment-890526345
@jerryshao @mgaido91 would you please help to review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] mgaido91 commented on pull request #325: [LIVY-865][SERVER] Fix bug that Livy identifies valid yarn state of batch session as FAILED
Posted by GitBox <gi...@apache.org>.
mgaido91 commented on pull request #325:
URL: https://github.com/apache/incubator-livy/pull/325#issuecomment-891027399
I am not familiar with this part, sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org