You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2023/05/01 00:24:03 UTC

[Impala-ASF-CR] WIP IMPALA-12060: Only allow a single catalog instance in a cluster

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19826


Change subject: WIP IMPALA-12060: Only allow a single catalog instance in a cluster
......................................................................

WIP IMPALA-12060: Only allow a single catalog instance in a cluster

Impala doesn't support multiple catalogd instances to be part of
a cluster. When using external Active Passive HA mechanisms like
leader election, it may be possible for multiple catalog instances
to be added in one cluster, in some cases.

This patch fixs the issue by using statestore to ensure that there
could only be a single instance of catalogd to be registered in a
cluster. When a statestore subscriber in recovery mode, it will
resolve its heartbeat address before re-registering to statestore.
This prevents catalogd in passive mode from attempting to join the
cluster.

Testing:
 - Passed the core tests.
 - TODO unit-test

Change-Id: I3f96122dc4d080b7cc5b4a7f3c2f27d336c2b288
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
4 files changed, 80 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/19826/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f96122dc4d080b7cc5b4a7f3c2f27d336c2b288
Gerrit-Change-Number: 19826
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>

[Impala-ASF-CR] WIP IMPALA-12060: Only allow a single catalog instance in a cluster

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19826 )

Change subject: WIP IMPALA-12060: Only allow a single catalog instance in a cluster
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12900/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f96122dc4d080b7cc5b4a7f3c2f27d336c2b288
Gerrit-Change-Number: 19826
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 00:45:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-12060: Support CatalogD HA

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has abandoned this change. ( http://gerrit.cloudera.org:8080/19826 )

Change subject: WIP IMPALA-12060: Support CatalogD HA
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/19826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3f96122dc4d080b7cc5b4a7f3c2f27d336c2b288
Gerrit-Change-Number: 19826
Gerrit-PatchSet: 19
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP IMPALA-12060: Only allow a single catalog instance in a cluster

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has removed Abhishek Rawat from this change.  ( http://gerrit.cloudera.org:8080/19826 )

Change subject: WIP IMPALA-12060: Only allow a single catalog instance in a cluster
......................................................................


Removed reviewer Abhishek Rawat.
-- 
To view, visit http://gerrit.cloudera.org:8080/19826
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I3f96122dc4d080b7cc5b4a7f3c2f27d336c2b288
Gerrit-Change-Number: 19826
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>