You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/12/03 12:56:02 UTC

[GitHub] [drill] dzamo opened a new pull request #2393: DRILL-8066: Convert non-finite floating point literals to string RexLiterals

dzamo opened a new pull request #2393:
URL: https://github.com/apache/drill/pull/2393


   # [DRILL-8066](https://issues.apache.org/jira/browse/DRILL-8066): Convert non-finite floating point literals to string RexLiterals
   
   ## Description
   
   When we encounter floating point literals in a query we attempt to convert them to BigDecimal which can only handle finite floats. making queries like this fail: `select cast('-Infinity' as float);`.  This change sends non-finite floats to Strings.
   
   ## Documentation
   None.
   
   ## Testing
   New unit test: TestMathFunctionsWithNanInf#testNanInfLiteralConversion
   Manually run `select cast('-Infinity' as float);`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] dzamo merged pull request #2393: DRILL-8066: Convert non-finite floating point literals to string RexLiterals

Posted by GitBox <gi...@apache.org>.

dzamo merged pull request #2393:
URL: https://github.com/apache/drill/pull/2393


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org