You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/17 23:12:12 UTC

[GitHub] [incubator-superset] dleclere commented on a change in pull request #8333: [WiP] docs: plug the Hello World plugin

dleclere commented on a change in pull request #8333: [WiP] docs: plug the Hello World plugin
URL: https://github.com/apache/incubator-superset/pull/8333#discussion_r380394103
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -764,6 +764,11 @@ def query_obj(self):
         return d
 
 
+class HelloWorld(BaseViz):
 
 Review comment:
   I just lost a lot of time coming to this realisation :( 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org