You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2011/02/28 17:43:37 UTC
[jira] Commented: (MAPREDUCE-1343) Scope Change -
FileOutputCommitter # SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, package default to
public
[ https://issues.apache.org/jira/browse/MAPREDUCE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000384#comment-13000384 ]
Hadoop QA commented on MAPREDUCE-1343:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429089/MAPREDUCE-1343.patch
against trunk revision 1075216.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/88//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/88//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/88//console
This message is automatically generated.
> Scope Change - FileOutputCommitter # SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, package default to public
> -------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1343
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1343
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: MAPREDUCE-1343.patch
>
>
> Being a configuration property - it should be public static for apps to set /reset the property as opposed to hardcoding the string.
> Scope changed from package default to public.
> Also - enhanced with javadocs around the same.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira