You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/09/12 05:52:20 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #34260: Remove unnecessary call to keys() method on dictionaries

potiuk commented on code in PR #34260:
URL: https://github.com/apache/airflow/pull/34260#discussion_r1322423506


##########
airflow/providers/google/cloud/utils/field_validator.py:
##########
@@ -443,7 +443,7 @@ def validate(self, body_to_validate: dict) -> None:
                     and nested_union_spec.get("api_version") != self._api_version
                 ]
             )
-        for field_name in body_to_validate.keys():
+        for field_name in body_to_validate:

Review Comment:
   ```
   >>> x = None
   >>> x.keys()
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   AttributeError: 'NoneType' object has no attribute 'keys'
   >>>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org