You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/09 11:45:12 UTC
[GitHub] [flink] dianfu opened a new pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
dianfu opened a new pull request #17216:
URL: https://github.com/apache/flink/pull/17216
## What is the purpose of the change
*This pull request fixes the issue that the configurations defined in flink-conf.yaml and environment variables are not respected when executing in local mode*
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17216:
URL: https://github.com/apache/flink/pull/17216#issuecomment-916047587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d5b847be120bfed01a0da49d2534d55b815624",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64d5b847be120bfed01a0da49d2534d55b815624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d5b847be120bfed01a0da49d2534d55b815624 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17216:
URL: https://github.com/apache/flink/pull/17216#issuecomment-916047587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d5b847be120bfed01a0da49d2534d55b815624",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23850",
"triggerID" : "64d5b847be120bfed01a0da49d2534d55b815624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d5b847be120bfed01a0da49d2534d55b815624 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #17216:
URL: https://github.com/apache/flink/pull/17216#discussion_r706960738
##########
File path: flink-python/pyflink/pyflink_gateway_server.py
##########
@@ -30,27 +30,41 @@
from pyflink.find_flink_home import _find_flink_home, _find_flink_source_root
+KEY_ENV_LOG_DIR = "env.log.dir"
+KEY_ENV_YARN_CONF_DIR = "env.yarn.conf.dir"
+KEY_ENV_HADOOP_CONF_DIR = "env.hadoop.conf.dir"
+KEY_ENV_HBASE_CONF_DIR = "env.hbase.conf.dir"
+KEY_ENV_JAVA_HOME = "env.java.home"
+KEY_ENV_JAVA_OPTS = "env.java.opts"
+
def on_windows():
return platform.system() == "Windows"
-def find_java_executable():
- java_executable = "java.exe" if on_windows() else "java"
- flink_home = _find_flink_home()
- flink_conf_path = os.path.join(flink_home, "conf", "flink-conf.yaml")
- java_home = None
-
+def read_from_config(key, default_value, flink_conf_file):
+ value = default_value
Review comment:
```suggestion
def read_from_config(key, value, flink_conf_file):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17216:
URL: https://github.com/apache/flink/pull/17216#issuecomment-916021428
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 64d5b847be120bfed01a0da49d2534d55b815624 (Thu Sep 09 11:57:10 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18880).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #17216:
URL: https://github.com/apache/flink/pull/17216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17216: [FLINK-18880][python] Respect configurations defined in flink-conf.yaml and environment variables when executing in local mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17216:
URL: https://github.com/apache/flink/pull/17216#issuecomment-916047587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d5b847be120bfed01a0da49d2534d55b815624",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23850",
"triggerID" : "64d5b847be120bfed01a0da49d2534d55b815624",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d5b847be120bfed01a0da49d2534d55b815624 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23850)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org