You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/27 02:29:54 UTC

[GitHub] [skywalking] kezhenxu94 commented on pull request #9851: Split TCP related service mesh metrics protobuffer definition

kezhenxu94 commented on PR #9851:
URL: https://github.com/apache/skywalking/pull/9851#issuecomment-1292885858

   > As upstream is not merged yet, do we have connection ID logic in this PR?
   
   This PR doesn't include the fix, it's essentially a refactor and all works just like before.
   
   When the upstream Envoy fix is merged, we can start to tackle the connection ID and that see what else is needed for that case.
   
   I'm also OK to postpone this PR until when upstream Envoy fix gets merged, just wanted to minimize the changes in a single PR and separate these two things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org