You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:54:50 UTC
[GitHub] [incubator-teaclave] ya0guang opened a new pull request #508: polished documents
ya0guang opened a new pull request #508:
URL: https://github.com/apache/incubator-teaclave/pull/508
## Description
Polished the documents of adding custom executor, correct some typos.
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [X] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [ ] If you've changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun merged pull request #508: polished documents
Posted by GitBox <gi...@apache.org>.
mssun merged pull request #508:
URL: https://github.com/apache/incubator-teaclave/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org
[GitHub] [incubator-teaclave] mssun commented on a change in pull request #508: polished documents
Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #508:
URL: https://github.com/apache/incubator-teaclave/pull/508#discussion_r654111865
##########
File path: README.md
##########
@@ -48,6 +48,7 @@ platform, making computation on privacy-sensitive data safe and simple.
- [Access Control](docs/access-control.md)
- [Build System](docs/build-system.md)
- [Teaclave Service Internals](docs/service-internals.md)
+- [Adding Executors](adding-executors.md)
Review comment:
`docs/adding-executors.md`
##########
File path: docs/adding-executors.md
##########
@@ -0,0 +1,48 @@
+---
+permalink: /docs/adding-executors
+---
+
+# Adding Executors
+
+Teaclave supports several function executors currently: `builtin`, `mesapy` and
+`wamr`(WebAssembly Micro Runtime). For more information about current function
Review comment:
=> `wamr` (WebAssembly)
Missing a space.
##########
File path: docs/adding-executors.md
##########
@@ -0,0 +1,48 @@
+---
+permalink: /docs/adding-executors
+---
+
+# Adding Executors
+
+Teaclave supports several function executors currently: `builtin`, `mesapy` and
+`wamr`(WebAssembly Micro Runtime). For more information about current function
+executors, please check [this link]().
Review comment:
this link is missing
##########
File path: docs/adding-executors.md
##########
@@ -0,0 +1,48 @@
+---
+permalink: /docs/adding-executors
+---
+
+# Adding Executors
+
+Teaclave supports several function executors currently: `builtin`, `mesapy` and
+`wamr`(WebAssembly Micro Runtime). For more information about current function
+executors, please check [this link]().
+
+However, sometimes service providers may found current executors built in
Review comment:
In Teaclave, we call "service providers" as "platform providers" who provide the Teaclave platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org