You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by karanmehta93 <gi...@git.apache.org> on 2018/08/16 22:17:45 UTC

[GitHub] phoenix pull request #327: PHOENIX-4834 PhoenixMetricsLog interface methods ...

GitHub user karanmehta93 opened a pull request:

    https://github.com/apache/phoenix/pull/327

    PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on…

    … specific logger
    
    @ankitsinghal I did some refactoring in tests and added new tests for the scenario along with now logging metrics both on close and commit. Hence, a quick look at PR would be helpful.
    There is one more small pending problem, metrics won't be logged when auto_commit is set to true. Will file a separate Jira for that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #327
    
----
commit 6c95b6d5fe308d85a17709db50493dfa6a61628b
Author: Karan Mehta <ka...@...>
Date:   2018-08-16T22:08:12Z

    PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on specific logger

----


---

[GitHub] phoenix pull request #327: PHOENIX-4835 LoggingPhoenixConnection should log ...

Posted by karanmehta93 <gi...@git.apache.org>.

Github user karanmehta93 closed the pull request at:

    https://github.com/apache/phoenix/pull/327


---