You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:03:20 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
masayuki2009 opened a new pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738
## Summary
- I noticed that init task consumes more stack when executing wget
- Finally, I found that the default NETDB_DNSCLIENT_NAMESIZE
was changed recently
- This commit adjusts CONFIG_NETDB_DNSCLIENT_NAMESIZE to the
previous value
## Impact
- None
## Testing
- Tested with spresense:wifi_smp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 closed pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
masayuki2009 closed pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#issuecomment-954407268
> Finally, I found that the default NETDB_DNSCLIENT_NAMESIZE
was changed recently
i think it's better to revert the change.
https://github.com/apache/incubator-nuttx/pull/4739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#issuecomment-954424272
I think we should dynamically allocate buffer for dns_send_query() instead of this PR.
I will create a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#discussion_r738905808
##########
File path: boards/arm/cxd56xx/spresense/configs/rndis/defconfig
##########
@@ -77,6 +77,7 @@ CONFIG_MTD_SMART_SECTOR_SIZE=4096
CONFIG_NAME_MAX=765
Review comment:
should we change CONFIG_NAME_MAX to a small value, but extend CONFIG_PATH_MAX instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#issuecomment-954408206
> > Finally, I found that the default NETDB_DNSCLIENT_NAMESIZE
> > was changed recently
>
> i think it's better to revert the change. #4739
It look like the config make a wrong configuration:
CONFIG_NAME_MAX=768
CONFIG_PATH_MAX=256
It doesn't make any senses that file name length is bigger than path name length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#issuecomment-954409592
> > > Finally, I found that the default NETDB_DNSCLIENT_NAMESIZE
> > > was changed recently
> >
> >
> > i think it's better to revert the change. #4739
>
> It look like the config is wrong: CONFIG_NAME_MAX=768 CONFIG_PATH_MAX=256 It doesn't make any sense that file name length is bigger than path name length.
i agree it doesn't make sense.
but it's a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4738: Adjust dnsclient namesize for spresense and lc823450-xgevk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4738:
URL: https://github.com/apache/incubator-nuttx/pull/4738#issuecomment-954408206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org