You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/20 03:15:04 UTC
[GitHub] [incubator-iotdb] zhanglingzhe0820 opened a new pull request #925:
update merge recover
zhanglingzhe0820 opened a new pull request #925: update merge recover
URL: https://github.com/apache/incubator-iotdb/pull/925
update merge recover close
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #925: update merge
recover
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #925: update merge recover
URL: https://github.com/apache/incubator-iotdb/pull/925
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#925: update merge recover
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #925: update merge recover
URL: https://github.com/apache/incubator-iotdb/pull/925#discussion_r395449867
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/MergeFileTask.java
##########
@@ -173,6 +173,13 @@ private void moveMergedToOld(TsFileResource seqFile) throws IOException {
seqFile.setFile(nextMergeVersionFile);
} catch (Exception e) {
logger.error(e.getMessage(), e);
+ RestorableTsFileIOWriter oldFileRecoverWriter = new RestorableTsFileIOWriter(
+ seqFile.getFile());
+ if (oldFileRecoverWriter.hasCrashed() && oldFileRecoverWriter.canWrite()) {
+ oldFileRecoverWriter.endFile();
+ } else {
+ oldFileRecoverWriter.close();
+ }
Review comment:
the e should be thrown againe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services