You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/17 04:44:38 UTC

[GitHub] [nuttx] anchao commented on a diff in pull request #8129: net/tcp: correct behavior of SO_LINGER

anchao commented on code in PR #8129:
URL: https://github.com/apache/nuttx/pull/8129#discussion_r1071731272


##########
net/socket/Kconfig:
##########
@@ -43,7 +43,6 @@ config NET_SOLINGER
 	bool "SO_LINGER socket option"
 	default n
 	depends on NET_TCP_WRITE_BUFFERS || NET_UDP_WRITE_BUFFERS
-	select NET_TCP_NOTIFIER if NET_TCP
 	select NET_UDP_NOTIFIER if NET_UDP

Review Comment:
   @acassis ,
   
   now all TCP data transmission is carried out by tcp_timer(), so we can delete the dependence on NET_TCP_NOTIFIER to avoid blocking for user thread.
   UDP data transmission does not need to wait for the reply of the ACK confirmation as long as the data can be sent successfully, so we keep the logic of NET_UDP_NOTIFIER(txdrain) when udp close



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org