[jira] [Commented] (MPLUGIN-304) MojoAnnotationsScanner should ignore special classes

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPLUGIN-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385035#comment-15385035 ] 

Hudson commented on MPLUGIN-304:
--------------------------------

SUCCESS: Integrated in maven-plugin-tools #253 (See [https://builds.apache.org/job/maven-plugin-tools/253/])
[MPLUGIN-304] MojoAnnotationsScanner should ignore special classes (rfscholte: [http://svn.apache.org/viewvc/?view=rev&rev=1753419])
* maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
* maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner
* maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScannerTest.java
* maven-plugin-tools-annotations/src/test/resources
* maven-plugin-tools-annotations/src/test/resources/java9-module.jar


> MojoAnnotationsScanner should ignore special classes
> ----------------------------------------------------
>
>                 Key: MPLUGIN-304
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-304
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: maven-plugin-tools-annotations
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>             Fix For: 3.5
>
>
> When a jar contains a {{module-info.class}} the scanner breaks with an IllegalArgumentException. This file will never contain Mojo Annotations, so it should can be safely skipped.
> To be forward compatible we could actually skip all classfiles containing a '-', since such files are considered classes with a special purpose.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)