[jira] Closed: (ASYNCWEB-20) CharsetDecoder in HttpDecoder is shared by multiple threads

["Sangjin Lee (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ASYNCWEB-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sangjin Lee closed ASYNCWEB-20.
-------------------------------

       Resolution: Fixed
    Fix Version/s: client-1.0.0

Introduced a thread local of CharsetDecoders so that we retain the performance optimization but do not share the instances.

> CharsetDecoder in HttpDecoder is shared by multiple threads
> -----------------------------------------------------------
>
>                 Key: ASYNCWEB-20
>                 URL: https://issues.apache.org/jira/browse/ASYNCWEB-20
>             Project: Asyncweb
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: client-1.0.0
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>             Fix For: client-1.0.0
>
>
> CharsetDecoder and CharsetEncoder are not safe for concurrent use.  However, the CharsetDecoder variable (decoder) in HttpDecoder is shared by multiple threads.  There is only one instance of HttpDecoder per AsyncHttpClient instance.  The CharsetDecoder object should not be shared by multiple threads.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.